[GitHub] [spark] amaliujia commented on a diff in pull request #40498: [SPARK-42878][CONNECT] The table API in DataFrameReader could also accept options

amaliujia commented on code in PR #40498: URL: https://github.com/apache/spark/pull/40498#discussion_r1145563490 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala: ## @@ -458,7 +458,9 @@ class DataFrameReader private[sql] (sparkSession:

[GitHub] [spark] amaliujia commented on a diff in pull request #40498: [SPARK-42878][CONNECT] The table API in DataFrameReader could also accept options

amaliujia commented on code in PR #40498: URL: https://github.com/apache/spark/pull/40498#discussion_r1145530854 ## python/pyspark/sql/connect/plan.py: ## @@ -302,13 +302,16 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: class Read(LogicalPlan): -

[GitHub] [spark] amaliujia commented on a diff in pull request #40498: [SPARK-42878][CONNECT] The table API in DataFrameReader could also accept options

amaliujia commented on code in PR #40498: URL: https://github.com/apache/spark/pull/40498#discussion_r1142929343 ## connector/connect/common/src/main/protobuf/spark/connect/relations.proto: ## @@ -148,6 +143,13 @@ message Read { // This is only supported by the JDBC data

[GitHub] [spark] amaliujia commented on a diff in pull request #40498: [SPARK-42878][CONNECT] The table API in DataFrameReader could also accept options

amaliujia commented on code in PR #40498: URL: https://github.com/apache/spark/pull/40498#discussion_r1142929171 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala: ## @@ -183,7 +183,7 @@ class DataFrameReader private[sql] (sparkSession: