[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-09-06 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r964020570 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala: ## @@ -361,6 +361,18 @@ object KeyGroupedPartitioning {

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-09-06 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r963886001 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala: ## @@ -361,6 +361,18 @@ object KeyGroupedPartitioning {

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-09-02 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r962077351 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala: ## @@ -361,6 +361,18 @@ object KeyGroupedPartitioning {

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-09-02 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r962076870 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala: ## @@ -361,6 +361,18 @@ object KeyGroupedPartitioning {

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-09-01 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r961236436 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala: ## @@ -105,18 +105,27 @@ object V2ExpressionUtils extends

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-09-01 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r961211655 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala: ## @@ -105,18 +105,27 @@ object V2ExpressionUtils extends

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-09-01 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r961043795 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala: ## @@ -105,18 +105,27 @@ object V2ExpressionUtils extends

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-08-31 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r960216556 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala: ## @@ -105,18 +105,27 @@ object V2ExpressionUtils extends

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-08-31 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r960207282 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala: ## @@ -105,18 +105,27 @@ object V2ExpressionUtils extends

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-08-31 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r960072719 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala: ## @@ -105,18 +105,27 @@ object V2ExpressionUtils extends

[GitHub] [spark] aokolnychyi commented on a diff in pull request #37749: [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering

2022-08-31 Thread GitBox
aokolnychyi commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r960057109 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala: ## @@ -105,18 +105,27 @@ object V2ExpressionUtils extends