[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-27 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r495661956 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,80 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-17 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r490664576 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,81 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-17 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r490664423 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,81 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-17 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r490663142 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,81 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489256112 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part3.sql.out ## @@ -385,6 +385,15 @@

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489252543 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala ## @@ -233,6 +233,17 @@ class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489247134 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,85 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489245255 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,85 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489243512 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -476,7 +476,7 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489187406 ## File path: sql/core/src/test/resources/sql-tests/inputs/window.sql ## @@ -124,4 +144,26 @@ WINDOW w AS (PARTITION BY cate ORDER BY val); -- with

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489187346 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-16 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489187186 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489145718 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489145248 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489128367 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489124118 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489123677 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-15 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r489121693 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -549,6 +549,96 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29604: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-09-02 Thread GitBox
beliefer commented on a change in pull request #29604: URL: https://github.com/apache/spark/pull/29604#discussion_r482664106 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -993,6 +993,64 @@ object functions { Lead(e.expr, Literal(offset),