[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r513153232 ## File path: sql/core/src/test/resources/sql-tests/results/window.sql.out ## @@ -479,6 +479,38 @@ Anthony Bow6627Gerard Bondur Leslie

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r513138536 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +173,93 @@ final class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r513133285 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala ## @@ -57,8 +57,12 @@ import

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512481955 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +169,69 @@ final class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512478210 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -171,18 +178,42 @@ trait WindowExecBase extends

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512477822 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala ## @@ -58,7 +58,7 @@ import

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512468539 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -355,6 +344,36 @@ abstract class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512387980 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +169,69 @@ final class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512387456 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +169,69 @@ final class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512381721 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -172,17 +179,41 @@ trait WindowExecBase extends

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512376963 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -136,8 +136,15 @@ trait WindowExecBase extends

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512376471 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -355,6 +344,35 @@ abstract class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r510808186 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -355,6 +344,35 @@ abstract class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r510791572 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -136,8 +136,15 @@ trait WindowExecBase extends

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r510781235 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -355,6 +344,35 @@ abstract class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r509983342 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -136,8 +136,15 @@ trait WindowExecBase extends

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r509957584 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -136,8 +136,15 @@ trait WindowExecBase extends

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r509933808 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -327,25 +327,14 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r503782816 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -327,38 +327,56 @@ object

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r503179138 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -347,18 +341,51 @@ abstract class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r503178031 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -617,10 +639,16 @@ case class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r502165124 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -136,8 +136,15 @@ trait WindowExecBase extends

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r502165124 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -136,8 +136,15 @@ trait WindowExecBase extends

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r502165838 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala ## @@ -151,10 +169,69 @@ final class

[GitHub] [spark] beliefer commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

beliefer commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r502165124 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -136,8 +136,15 @@ trait WindowExecBase extends