[GitHub] [spark] beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

2019-05-28 Thread GitBox
beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-496760641 @srowen Thanks for your help. @gaborgsomogyi @HeartSaVioR Thanks for your review.

[GitHub] [spark] beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

2019-05-21 Thread GitBox
beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-494626017 Based on the above discussion, we all not sure the contract whether providers are required to be stateless. So I

[GitHub] [spark] beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

2019-05-21 Thread GitBox
beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-494279594 > 1. This patch will show different behavior if provider provides different instance per constructor call (this is

[GitHub] [spark] beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

2019-05-21 Thread GitBox
beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-494266375 > > I'm not sure about the contract here, whether providers are required to be stateless. If they're not then this

[GitHub] [spark] beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

2019-05-20 Thread GitBox
beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-494215705 > > I'm not sure about the contract here, whether providers are required to be stateless. > > Since

[GitHub] [spark] beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

2019-05-20 Thread GitBox
beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-494214438 > I'm not sure about the contract here, whether providers are required to be stateless. If they're not then this

[GitHub] [spark] beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

2019-05-20 Thread GitBox
beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-493908403 test please This is an automated message from the

[GitHub] [spark] beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

2019-05-20 Thread GitBox
beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-493908273 cc @dongjoon-hyun @srowen This is an automated