[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463417776 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class CollapseCodegenStages(

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463417776 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class CollapseCodegenStages(

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463416899 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class CollapseCodegenStages(

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463403584 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class CollapseCodegenStages(

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463395132 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class CollapseCodegenStages(

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463165676 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala ## @@ -903,6 +904,10 @@ case class CollapseCodegenStages(

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r463161938 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -70,4 +74,24 @@ case class ShuffledHashJoinExec(

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r462830406 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -70,4 +74,54 @@ case class ShuffledHashJoinExec(

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-30 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r462677816 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ## @@ -316,6 +318,387 @@ trait HashJoin extends BaseJoinExec {

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-29 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r462401733 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ## @@ -316,6 +318,387 @@ trait HashJoin extends BaseJoinExec {

[GitHub] [spark] c21 commented on a change in pull request #29277: [SPARK-32421][SQL] Add code-gen for shuffled hash join

2020-07-29 Thread GitBox
c21 commented on a change in pull request #29277: URL: https://github.com/apache/spark/pull/29277#discussion_r461912796 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -70,4 +74,69 @@ case class ShuffledHashJoinExec(