[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-29 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549936158 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -154,13 +154,54 @@ class DataSourceV2SQLSuite

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-29 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549935749 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -764,13 +765,13 @@ case class DescribeColumnCommand(

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-29 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549935311 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -235,8 +237,21 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-29 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549933484 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -235,8 +237,21 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-29 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549933194 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -235,8 +237,21 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549602461 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -235,8 +236,17 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549592550 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -272,8 +273,13 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549592416 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -235,8 +236,17 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549591975 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -235,8 +236,17 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-27 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549236685 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1675,6 +1675,13 @@ class Analyzer(override val

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-27 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549236194 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1675,6 +1675,13 @@ class Analyzer(override val

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-27 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r549236035 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1675,6 +1675,13 @@ class Analyzer(override val

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-25 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r548838750 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala ## @@ -97,9 +98,21 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-25 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r548830290 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1675,6 +1675,13 @@ class Analyzer(override val

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-25 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r548830073 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1675,6 +1675,13 @@ class Analyzer(override val

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-25 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r548829115 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -272,8 +272,14 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-23 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r548399246 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -344,10 +344,11 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-23 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r547946465 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -344,10 +344,11 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #30881: [SPARK-33875][SQL] Implement DESCRIBE COLUMN for v2 tables

2020-12-22 Thread GitBox
cloud-fan commented on a change in pull request #30881: URL: https://github.com/apache/spark/pull/30881#discussion_r547128251 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -344,10 +344,11 @@ case class