[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r573416874 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala ## @@ -72,17 +72,15 @@ object BindReferences e

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571986698 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala ## @@ -157,7 +156,7 @@ case class ExplainCommand( overri

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r570991936 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ## @@ -504,8 +504,7 @@ abstract class TreeNode[BaseType <:

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571985735 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ## @@ -504,8 +504,7 @@ abstract class TreeNode[BaseType <:

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571842005 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class RuleExecutor[Tre

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r570991936 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ## @@ -504,8 +504,7 @@ abstract class TreeNode[BaseType <:

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r570990684 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ## @@ -35,7 +35,7 @@ import org.apache.spark.sql.util

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r570988808 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala ## @@ -72,17 +71,15 @@ object BindReferences e