[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r755791057 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -1294,13 +1294,25 @@ class DataSourceV2SQLSuite

[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r755790090 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -44,7 +45,8 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r754984133 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -349,7 +351,7 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-23 Thread GitBox
cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r754983417 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -349,7 +351,7 @@ case class