[GitHub] [spark] cloud-fan commented on a diff in pull request #36265: [SPARK-38951][SQL] Aggregate aliases override field names in ResolveAggregateFunctions

cloud-fan commented on code in PR #36265: URL: https://github.com/apache/spark/pull/36265#discussion_r979562710 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -2594,6 +2601,31 @@ class Analyzer(override val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36265: [SPARK-38951][SQL] Aggregate aliases override field names in ResolveAggregateFunctions

cloud-fan commented on code in PR #36265: URL: https://github.com/apache/spark/pull/36265#discussion_r866863003 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -2563,7 +2563,23 @@ class Analyzer(override val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36265: [SPARK-38951][SQL] Aggregate aliases override field names in ResolveAggregateFunctions

cloud-fan commented on code in PR #36265: URL: https://github.com/apache/spark/pull/36265#discussion_r866859656 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -2563,7 +2563,23 @@ class Analyzer(override val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36265: [SPARK-38951][SQL] Aggregate aliases override field names in ResolveAggregateFunctions

cloud-fan commented on code in PR #36265: URL: https://github.com/apache/spark/pull/36265#discussion_r866856072 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -2563,7 +2563,23 @@ class Analyzer(override val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36265: [SPARK-38951][SQL] Aggregate aliases override field names in ResolveAggregateFunctions

cloud-fan commented on code in PR #36265: URL: https://github.com/apache/spark/pull/36265#discussion_r866842272 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala: ## @@ -1176,4 +1176,13 @@ class AnalysisSuite extends AnalysisTest with

[GitHub] [spark] cloud-fan commented on a diff in pull request #36265: [SPARK-38951][SQL] Aggregate aliases override field names in ResolveAggregateFunctions

cloud-fan commented on code in PR #36265: URL: https://github.com/apache/spark/pull/36265#discussion_r866842272 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala: ## @@ -1176,4 +1176,13 @@ class AnalysisSuite extends AnalysisTest with