[GitHub] [spark] cloud-fan commented on a diff in pull request #39509: [SPARK-41635][SQL] Fix group by all error reporting

2023-01-11 Thread GitBox
cloud-fan commented on code in PR #39509: URL: https://github.com/apache/spark/pull/39509#discussion_r1067633765 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupByAll.scala: ## @@ -93,8 +93,9 @@ object ResolveGroupByAll extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #39509: [SPARK-41635][SQL] Fix group by all error reporting

2023-01-11 Thread GitBox
cloud-fan commented on code in PR #39509: URL: https://github.com/apache/spark/pull/39509#discussion_r1066909968 ## sql/core/src/test/resources/sql-tests/inputs/group-by-all.sql: ## @@ -75,8 +75,11 @@ select (id + id) / 2 + count(*) * 2 from data group by all; select country,