cloud-fan commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-723806419
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-721545793
> ... send properties to underlying databases and let databases decide
whether to fail the CREATE TALBE or not
This works. Does it conflict with the dialect API to
cloud-fan commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-721519171
I think the principle is: when users specify some table properties, JDBC V2
should fail if the underlying database can't support the properties.
I prefer a dialect API
cloud-fan commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-719284981
> This query is different for different databases
ah, it's so complicated. Let's forget about it for this PR.
cloud-fan commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-718404878
We also need to retrieve the table comment in `TableCatalog.loadTable`
This is an automated message from the
