[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-05 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r518397566 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-04 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517808712 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-04 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517695469 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-04 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517695152 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-04 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517155989 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517154290 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala ## @@ -50,4 +50,17 @@ private object DerbyDialect extends

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-11-03 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r516384753 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-10-29 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r514715480 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -123,8 +123,14 @@ class

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-10-29 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r514657593 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -123,8 +123,14 @@ class

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-10-28 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r513603989 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -258,6 +258,10 @@ abstract class JdbcDialect extends

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

2020-10-26 Thread GitBox
huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r512420953 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -123,8 +123,14 @@ class