[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-23 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r581323742 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableProperties.scala ## @@ -0,0 +1,43 @@ +/* + * Licensed to th

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-23 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r581312258 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableProperties.scala ## @@ -0,0 +1,43 @@ +/* + * Licensed to th

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-23 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r581289955 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableProperties.scala ## @@ -0,0 +1,43 @@ +/* + * Licensed to th

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-10 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r574240206 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala ## @@ -1141,6 +1141,36 @@ trait AlterTableTests extends Share

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-08 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r572353356 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala ## @@ -1141,6 +1141,36 @@ trait AlterTableTests extends Share

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-08 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r572305204 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala ## @@ -1141,6 +1141,36 @@ trait AlterTableTests extends Share

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-08 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r572291602 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableProperties.scala ## @@ -0,0 +1,43 @@ +/* + * Licensed to th

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-08 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r572290672 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java ## @@ -64,7 +64,20 @@ static TableChange setProperty(St

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-05 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r571342363 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -437,9 +437,8 @@ class DataSourceV2

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-05 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r571342363 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -437,9 +437,8 @@ class DataSourceV2

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-05 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r571282171 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala ## @@ -116,7 +116,11 @@ private[sql] object Catalog

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-05 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r571282171 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala ## @@ -116,7 +116,11 @@ private[sql] object Catalog

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-05 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r571240319 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java ## @@ -64,7 +64,20 @@ static TableChange setProperty(St

[GitHub] [spark] imback82 commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-05 Thread GitBox
imback82 commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r571240319 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java ## @@ -64,7 +64,20 @@ static TableChange setProperty(St