[GitHub] [spark] maropu commented on a change in pull request #28869: [SPARK-32031][SQL] Fix the wrong references of the PartialMerge/Final AggregateExpression

2020-06-19 Thread GitBox
maropu commented on a change in pull request #28869: URL: https://github.com/apache/spark/pull/28869#discussion_r442764355 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala ## @@ -49,7 +49,7 @@ case class SortAggregateExec(

[GitHub] [spark] maropu commented on a change in pull request #28869: [SPARK-32031][SQL] Fix the wrong references of the PartialMerge/Final AggregateExpression

2020-06-19 Thread GitBox
maropu commented on a change in pull request #28869: URL: https://github.com/apache/spark/pull/28869#discussion_r442761506 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/BaseAggregateExec.scala ## @@ -53,15 +53,24 @@ trait BaseAggregateExec

[GitHub] [spark] maropu commented on a change in pull request #28869: [SPARK-32031][SQL] Fix the wrong references of the PartialMerge/Final AggregateExpression

2020-06-19 Thread GitBox
maropu commented on a change in pull request #28869: URL: https://github.com/apache/spark/pull/28869#discussion_r442761087 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/BaseAggregateExec.scala ## @@ -53,15 +53,24 @@ trait BaseAggregateExec

[GitHub] [spark] maropu commented on a change in pull request #28869: [SPARK-32031][SQL] Fix the wrong references of the PartialMerge/Final AggregateExpression

2020-06-19 Thread GitBox
maropu commented on a change in pull request #28869: URL: https://github.com/apache/spark/pull/28869#discussion_r442757181 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala ## @@ -140,7 +140,7 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28869: [SPARK-32031][SQL] Fix the wrong references of the PartialMerge/Final AggregateExpression

2020-06-19 Thread GitBox
maropu commented on a change in pull request #28869: URL: https://github.com/apache/spark/pull/28869#discussion_r442756818 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/BaseAggregateExec.scala ## @@ -53,15 +53,24 @@ trait BaseAggregateExec

[GitHub] [spark] maropu commented on a change in pull request #28869: [SPARK-32031][SQL] Fix the wrong references of the PartialMerge/Final AggregateExpression

2020-06-19 Thread GitBox
maropu commented on a change in pull request #28869: URL: https://github.com/apache/spark/pull/28869#discussion_r442753564 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/BaseAggregateExec.scala ## @@ -53,15 +53,24 @@ trait BaseAggregateExec