[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r464257964 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -66,17 +69,28 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r464243896 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -66,17 +68,29 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r464238349 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -246,11 +246,17 @@ statement | SET TIME ZONE

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r464231505 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -66,17 +68,29 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r464224591 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -66,17 +68,29 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r464224591 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -66,17 +68,29 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r464224591 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -66,17 +68,29 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r464224591 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -66,17 +68,29 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r463377564 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -962,8 +962,8 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r463019812 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -962,8 +962,8 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r463019812 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -962,8 +962,8 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r462888722 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -962,8 +962,8 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r462884875 ## File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfEntrySuite.scala ## @@ -107,7 +107,7 @@ class SQLConfEntrySuite extends

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r462884139 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala ## @@ -61,6 +63,64 @@ class SparkSqlParserSuite extends

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r462884250 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -244,11 +258,31 @@ statement | SET TIME ZONE

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r462883994 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala ## @@ -61,6 +63,64 @@ class SparkSqlParserSuite extends

[GitHub] [spark] maropu commented on a change in pull request #29146: [SPARK-32257][SQL] Reports explicit errors for invalid usage of SET/RESET command

maropu commented on a change in pull request #29146: URL: https://github.com/apache/spark/pull/29146#discussion_r461230902 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -66,17 +69,21 @@ class SparkSqlAstBuilder(conf: SQLConf)