[GitHub] [spark] skambha commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-04 Thread GitBox
skambha commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-639187545 > @skambha You can check the integrated tests in #28725. If we delete the validation, we'll get a NPE for [this

[GitHub] [spark] skambha commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-02 Thread GitBox
skambha commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-637904536 @xuanyuanking , can you please explain how this will fix the issue where we have changed something in the internal implementation of sum in SPARK-28067, how does that affect