[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r452556162 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ## @@ -1230,16 +1230,10 @@ private[hive] object

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r452556092 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2721,6 +2707,68 @@ class HiveDDLSuite }

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r451227746 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ## @@ -1230,16 +1230,10 @@ private[hive] object

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448230855 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -115,6 +116,26 @@ case class CreateTableLikeCommand(

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448102285 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ## @@ -1066,7 +1066,10 @@ private[hive] object

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448066184 ## File path: docs/sql-ref-syntax-ddl-create-table-like.md ## @@ -57,6 +57,8 @@ CREATE TABLE [IF NOT EXISTS] table_identifier LIKE

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448064686 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -115,6 +116,26 @@ case class CreateTableLikeCommand(

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448055387 ## File path: docs/sql-ref-syntax-ddl-create-table-like.md ## @@ -57,6 +57,8 @@ CREATE TABLE [IF NOT EXISTS] table_identifier LIKE

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448055181 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -115,6 +116,26 @@ case class CreateTableLikeCommand(

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r446910478 ## File path: docs/sql-ref-syntax-ddl-create-table-like.md ## @@ -57,6 +57,8 @@ CREATE TABLE [IF NOT EXISTS] table_identifier LIKE

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r444589954 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,25 @@ case class

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r434406585 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r434403470 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r433872605 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r433580610 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r433130893 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432539576 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -1531,21 +1531,6 @@ class HiveDDLSuite

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432539576 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -1531,21 +1531,6 @@ class HiveDDLSuite

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432308450 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -115,6 +116,15 @@ case class CreateTableLikeCommand(

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432208610 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432208324 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2720,4 +2708,23 @@ class HiveDDLSuite