[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-07 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466843235 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,45 @@ trait OrcFiltersBase {

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466830881 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait OrcFiltersBase {

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466718934 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait OrcFiltersBase {

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466711647 ## File path: sql/core/v2.3/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala ## @@ -93,155 +92,200 @@ class

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466621878 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala ## @@ -78,7 +78,7 @@ abstract class OrcTest extends

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-08-06 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r466621878 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala ## @@ -78,7 +78,7 @@ abstract class OrcTest extends

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-06-29 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r447094702 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala ## @@ -78,12 +78,16 @@ abstract class OrcTest extends

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-06-28 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r446778323 ## File path: sql/core/v2.3/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala ## @@ -74,9 +75,9 @@ class OrcFilterSuite

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-06-28 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r446769137 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala ## @@ -78,12 +78,16 @@ abstract class OrcTest extends

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-06-10 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r437897971 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcV1FilterSuite.scala ## @@ -19,7 +19,7 @@ package

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-06-10 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r437897740 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait OrcFiltersBase {

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-06-10 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r437897212 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait OrcFiltersBase {

[GitHub] [spark] viirya commented on a change in pull request #28761: [SPARK-25557][SQL] Nested column predicate pushdown for ORC

2020-06-09 Thread GitBox
viirya commented on a change in pull request #28761: URL: https://github.com/apache/spark/pull/28761#discussion_r437827176 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala ## @@ -37,12 +40,44 @@ trait OrcFiltersBase {