[GitHub] [spark] viirya commented on a change in pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
viirya commented on a change in pull request #30245: URL: https://github.com/apache/spark/pull/30245#discussion_r517120205 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala ## @@ -149,17 +149,43 @@ class

[GitHub] [spark] viirya commented on a change in pull request #30245: [WIP][SPARK-33337][SQL] Support subexpression elimination in branches of conditional expressions

2020-11-03 Thread GitBox
viirya commented on a change in pull request #30245: URL: https://github.com/apache/spark/pull/30245#discussion_r517120205 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala ## @@ -149,17 +149,43 @@ class