[GitHub] [spark] wineternity commented on pull request #38702: [SPARK-41187][CORE] LiveExecutor MemoryLeak in AppStatusListener when ExecutorLost happen

2022-12-11 Thread GitBox
wineternity commented on PR #38702: URL: https://github.com/apache/spark/pull/38702#issuecomment-1345501343 > +1, LGTM. Thank you, @wineternity and all. my pleasure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] wineternity commented on pull request #38702: [SPARK-41187][CORE] LiveExecutor MemoryLeak in AppStatusListener when ExecutorLost happen

2022-12-11 Thread GitBox
wineternity commented on PR #38702: URL: https://github.com/apache/spark/pull/38702#issuecomment-1345497906 > my pleasure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] wineternity commented on pull request #38702: [SPARK-41187][CORE] LiveExecutor MemoryLeak in AppStatusListener when ExecutorLost happen

2022-12-06 Thread GitBox
wineternity commented on PR #38702: URL: https://github.com/apache/spark/pull/38702#issuecomment-1340463701 > The change looks good to me. +CC @Ngone51 > > Btw, do you also want to remove the `if (event.taskInfo == null) {` check in beginning of `onTaskEnd` ? > > Make it a

[GitHub] [spark] wineternity commented on pull request #38702: [SPARK-41187][CORE] LiveExecutor MemoryLeak in AppStatusListener when ExecutorLost happen

2022-11-24 Thread GitBox
wineternity commented on PR #38702: URL: https://github.com/apache/spark/pull/38702#issuecomment-1327055076 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] wineternity commented on pull request #38702: [SPARK-41187][Core] LiveExecutor MemoryLeak in AppStatusListener when ExecutorLost happen

2022-11-21 Thread GitBox
wineternity commented on PR #38702: URL: https://github.com/apache/spark/pull/38702#issuecomment-1321774634 @itholic @vanzin Could you help review this patch? thanks very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub