[GitHub] [spark] zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters

2019-09-27 Thread GitBox
zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#discussion_r328979198 ## File path: python/pyspark/ml/tests/test_param.py ## @@

[GitHub] [spark] zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters

2019-09-27 Thread GitBox
zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#discussion_r328973948 ## File path: python/pyspark/ml/feature.py ## @@ -1415,7

[GitHub] [spark] zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters

2019-09-24 Thread GitBox
zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#discussion_r327477108 ## File path: python/pyspark/ml/feature.py ## @@ -1349,6

[GitHub] [spark] zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters

2019-09-24 Thread GitBox
zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#discussion_r327481109 ## File path: python/pyspark/ml/feature.py ## @@ -1527,17

[GitHub] [spark] zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters

2019-09-24 Thread GitBox
zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#discussion_r327476081 ## File path: python/pyspark/ml/feature.py ## @@ -129,7 +129,7

[GitHub] [spark] zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters

2019-09-24 Thread GitBox
zhengruifeng commented on a change in pull request #25908: [SPARK-29143][PYTHON][ML] Pyspark feature models support column setters/getters URL: https://github.com/apache/spark/pull/25908#discussion_r327480321 ## File path: python/pyspark/ml/feature.py ## @@ -1130,8