HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-457430106
Merged to master.
This is an automated message from the
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-457430087
I am merging this based upon multiple approvals and positive feedbacks in
general. I am also confident that it's isolated
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-457036026
Thank you all so much. Could we maybe go forward?
This
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-455860035
Hey all, gentle ping ...
This is an automated message
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-454646029
Hey all, do you mind if I ask to take another look? I think I addressed all
comments, and the changes here are not
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-453890147
@mengxr ping ..
This is an automated message from the
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-453383896
@mengxr, can you take a look please when you're available?
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-453367798
retest this please
This is an automated message from the
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-452576021
Gentle ping @mengxr
This is an automated message from
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-451716230
Gentle ping @mengxr
This is an automated message from
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-451047629
gentle ping @mengxr. I think the comment is addressed .. I know it's been a
holiday period so everybody isn't quite
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-450536961
Hey, @mengxr, can you check if your comment is addressed?
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-450143241
retest this please
This is an automated message from the
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Instrumentation
URL: https://github.com/apache/spark/pull/23263#issuecomment-449685987
@mengxr, @srowen and @felixcheung, I think I managed to integrate and
address all the concerns and comments.
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-449571822
Let me give a shot to make it with ML instrumentation to show how it's going
to look like.
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-449199714
Like, if we fix
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-449198904
@mengxr, looks actually considered at here
https://github.com/apache/spark/pull/23263#issuecomment-447885870.
I also
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-449187069
I'm not used to ML side so it needs a while to check .. Let me check and be
back soon!
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-448539534
retest this please
This is an automated message from the
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-448077102
Oh! let me take a look.
This is an automated message from the
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-447858692
To make Atlas work for my case, any case is fine. I just need to catch the
events related with Pipeline and that's all.
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-447856497
Yes .. that's what I wanted to do and the previous change is really what it
needs as is ..
I can go back to the previous
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-447780841
To be absolutely conservative, I can even add a configuration switch if
anyone feels so.
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-447771837
I made the change smaller by only sending events at `Pipeline`s. So, it
should really be conservative enough in terms of being
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
URL: https://github.com/apache/spark/pull/23263#issuecomment-447731722
Yes .. right. I could add the wrapper `MLEvents.withTransformEvent { ... }`
to only Pipeline codes and only enable events support for it, for
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
URL: https://github.com/apache/spark/pull/23263#issuecomment-447228688
Hey @jkbradley, @mengxr, @dbtsai and @yanboliang, would you guys mind if I
ask to take a look please?
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
URL: https://github.com/apache/spark/pull/23263#issuecomment-446645768
Or should I maybe only do Pipeline related instances only?
This is an
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
URL: https://github.com/apache/spark/pull/23263#issuecomment-446509529
I tried to think few times but .. I couldn't think any other ways then this
.. Only way to make the changes less should be .. to let only few
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events
URL: https://github.com/apache/spark/pull/23263#issuecomment-446446483
I wanted to avoid a big change (also considering ML side is rather less
active) .. but this looked to me necessarily required changes to
29 matches
Mail list logo
