imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-458404664
@srowen thanks for the quick response, I've created a follow-up PR here:
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-458203376
I think I made a mistake and it should actually be:
```
val tolerance = Utils.EPSILON * (unweightedNumSamples
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-457997552
@srowen thank you for the merge and the thorough review. I have some doubts
about the tolerance we decided for
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-456670961
"up to your judgment on whether to add a new overload to
DecisionTreeMetadata to simplify the test code"
This is
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-453899345
@srowen thank you for taking another look at the PR. I think I have
addressed most comments except for two of
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-453666838
it looks like the test failures were unrelated, rebasing to latest to see if
it will fix them
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-453551478
jenkins retest this please
This is an
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-452782044
jenkins retest this please
This is an automated
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-449256537
@srowen thank you for the review! I think I have resolved most of the
comments except I had a question about the
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-449082192
jenkins retest this please
This is an automated
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-449081540
it looks like the test failure was a random failure in the build system not
related to the PR, going to try again
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-448626125
jenkins retest this please
This is an automated
imatiach-msft commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample
weights to decision trees
URL: https://github.com/apache/spark/pull/21632#issuecomment-446008052
jenkins retest this please (updated PR to latest)
13 matches
Mail list logo
