[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-10-09 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/12691 @srowen @holdenk I have created new branch, applied patch and created the new pull request. Closing this pull request. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-10-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/12691 @bkpathak you can just close this and reopen. Although you can fix this with git surgery and a force-push, sometimes it's not worth it if you can just branch, patch the commit(s) you want to keep,

[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-10-08 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/12691 Hi @holdenk I am still interested in working on this but it looks like I pull and merged with a master branch instead of rebasing it. Can I close it and open another pull request. Or how should I

[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-10-07 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/12691 Thanks for working on this @bkpathak :) Are you still interested in working on this? If so can you update this to the latest master and then we can try and find a committer to take a more thorough

[GitHub] spark issue #12691: [Spark-14761][SQL][WIP] Reject invalid join methods when...

2016-07-04 Thread bkpathak
Github user bkpathak commented on the issue: https://github.com/apache/spark/pull/12691 Hi @JoshRosen, could you please look at the pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not