Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
Thanks guys for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
Merged -- thanks for your work on this @lirui-intel!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70940/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70940 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70940/testReport)**
for PR 12775 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70940 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70940/testReport)**
for PR 12775 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
No the failure seems to be due to a failing hive context test in Pyspark
(look at the very end of the console output). I don't see how that could be
related to this PR and it passes locally
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
I think the failure is due to one more [skipped
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70890/testReport)**
for PR 12775 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70890/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70890 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70890/testReport)**
for PR 12775 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
(running one more test to make sure that it was Jenkins flakiness and not
flakiness due to this PR; then I'll merge this)
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70844/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70844 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70844/testReport)**
for PR 12775 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70844 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70844/testReport)**
for PR 12775 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
@lirui-intel I don't see any reason why this should cause increased
flakiness -- let's try Jenkins one more time.
---
If your project is set up for it, you can reply to this email and have
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
Not sure if my patch makes the tests unstable. But I can't figure out why.
@kayousterhout @mridulm any ideas?
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70513/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70513 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70513/testReport)**
for PR 12775 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70513 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70513/testReport)**
for PR 12775 at commit
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70458/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70458 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70458/testReport)**
for PR 12775 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
I don't think the failure is related, and it can't be reproduced locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70409/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70409 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70409/testReport)**
for PR 12775 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70409 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70409/testReport)**
for PR 12775 at commit
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/12775
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
The new test passed locally and I can't find any failures in the Jenkins
test report. Not sure what failed exactly.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70397/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70397 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70397/testReport)**
for PR 12775 at commit
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
Sure. Updated patch to not catch Throwable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
Ok that's fine with me -- @lirui-intel can you make that change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/12775
@kayousterhout Exactly. The logError is already handled elsewhere (and the
throwable it is not ignored there).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
@mridulm I see -- so you're saying to keep the finally block but remove
catching the Throwable? So eliminate the logError, but otherwise the
functionality is the same?
---
If your project
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/12775
@kayousterhout As @lirui-intel mentioned above, there are two parts to this
change.
One is moving handleFailedTask to finally - that is a correct change.
The other is catching
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
@mridulm what's the scenario you're imagining where it's worse to catch the
exception? I'm imagining one of two scenarios:
(1) There's a recoverable exception, in which case we
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
Hi @kayousterhout and @mridulm, to clarify, I think the error won't
disappear if we don't catch it. Because the runnable is wrapped in
Utils.logUncaughtExceptions so the error will be logged
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/12775
If intent is only to log, why not register an uncaughtException handler for
that purpose instead of catching Throwable and ignoring it after logging ?
---
If your project is set up for it,
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
@mridulm My thought here was we might as well catch it, since the thread
is about to die anyway. The alternative is that we don't catch it, the thread
dies (so the error disappears / we
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/12775
Just saw this - catching Throwable is problematic : it could be any system
related Error's too : which might leave the VM in inconsistent state if not
properly handled.
Like an OOM or a link
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70388/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70388 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70388/testReport)**
for PR 12775 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #70388 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70388/testReport)**
for PR 12775 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/12775
Yeah, that's ok, @kayousterhout
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
LGTM -- are you ok with merging this @markhamstra, after re-testing it
since it's been so long?
Sorry for neglecting this @lirui-intel!
---
If your project is set up for it, you can
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12775
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
Hi @kayousterhout and @markhamstra , could you take another look? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66624/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12775
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #66624 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66624/consoleFull)**
for PR 12775 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12775
**[Test build #66624 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66624/consoleFull)**
for PR 12775 at commit
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
Thanks for the review. Updated the patch to address the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lirui-intel commented on the issue:
https://github.com/apache/spark/pull/12775
Could anybody help review this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
66 matches
Mail list logo
