Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14650
I see you already pushed a fix, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14650
Guys this broke the build. Please don't use Option.contains in the future.
It is both confusing and not working for Scala 2.10.
---
If your project is set up for it, you can reply to this email and
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14650
This is already merged. Maybe there's something wrong with the apache /
github sync.
https://git-wip-us.apache.org/repos/asf?p=spark.git;a=commit;h=ea77c81ec0db27ea4709f71dc080d00167505a7d
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@vanzin if there is anything to fix I can do it if you want I can do
another parse to check it against the style guide. For all the style nit stuff
I guess sometimes is a matter of taste...
---
If
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14650
LGTM. There are a few style nits that I'll fix during the merge to avoid
another round.
Merging to master.
---
If your project is set up for it, you can reply to this email and have your
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14650
Since @vanzin has looked at this most closely I'd defer to him for a merge
when you both think it's ready.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@rxin @srowen could I get merge pls if there are no other issues?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68805/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #68805 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68805/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@vanzin I updated the PR. Thank you for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #68805 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68805/consoleFull)**
for PR 14650 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/14650
Not yet, I'll try to find some time today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14650
@vanzin did you do your 2nd pass?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@srowen could I get a merge please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68718/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #68718 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68718/consoleFull)**
for PR 14650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #68718 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68718/consoleFull)**
for PR 14650 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
I get some strange error with the jenkins build any idea?
```[error] (mesos/compile:compileIncremental) Compilation failed
[error] (core/test:compileIncremental) Compilation failed
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68715/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #68715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68715/consoleFull)**
for PR 14650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #68715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68715/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
jenkins please test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68714/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #68714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68714/consoleFull)**
for PR 14650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #68714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68714/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@vanzin pls review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
WIP
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@vanzin ok I will update the PR asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@mgummelt ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67066/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #67066 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67066/consoleFull)**
for PR 14650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #67066 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67066/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
jenkins please test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@vanzin & @srowen pls review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
WIP
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14650
OK I understand more about why the code is structured this way. Let me back
up another step before coming back to the details.
It feels like this change is trying to unify
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65594/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #65594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65594/consoleFull)**
for PR 14650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #65594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65594/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@srowen what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@srowen @mgummelt pls review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65358/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #65358 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65358/consoleFull)**
for PR 14650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #65358 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65358/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
WIP fixing test...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65333/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #65333 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65333/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@mgummelt @srowen I refactored a bit MesosSchedulerDispatcherArguments to
follow the SparkSubmit pattern. Re-used some code there. Added several tests.
---
If your project is set up for it, you
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #65333 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65333/consoleFull)**
for PR 14650 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65311/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #65311 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65311/consoleFull)**
for PR 14650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #65311 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65311/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
WIP
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14650
Responding to
https://github.com/apache/spark/pull/14650#issuecomment-241095780 , IMHO it's
best if configuration never uses environment variables or system properties.
They're global to a process
Github user mgummelt commented on the issue:
https://github.com/apache/spark/pull/14650
I'm generally fine with this, though one downside is that it introduces a
consistency with other daemon classes such as Master.scala, which only accepts
a properties file. Maybe we should make a
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@srowen could you merge it pls?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@mgummelt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14650
Seems OK to me, to the limits of my understanding, and given the logic of
https://github.com/apache/spark/pull/14650#issuecomment-240057336
---
If your project is set up for it, you can reply to
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@srowen @mgummelt what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
I think not.
MesosDispacther uses
[spark-daemon.sh](https://github.com/apache/spark/blob/master/sbin/start-mesos-dispatcher.sh#L44)
which uses
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14650
Does the existing spark-submit not work on Mesos?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63790/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #63790 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63790/consoleFull)**
for PR 14650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14650
**[Test build #63790 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63790/consoleFull)**
for PR 14650 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/14650
@mgummelt pls review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
75 matches
Mail list logo
