Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/15408
LGTM. Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15408
Going once, going twice, any more comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67016/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #67016 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67016/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67014/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #67014 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67014/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #67016 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67016/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #67014 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67014/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66978/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66978 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66978/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66978 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66978/consoleFull)**
for PR 15408 at commit
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/15408
jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66972/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66972/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66972/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66860/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66860/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66860 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66860/consoleFull)**
for PR 15408 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/15408
> I also missed why close() shouldn't be synchronized. You wouldn't want it
to take place during a read, right?
Good point. I was thinking `FileChannel.close` is safe but didn't consider
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66830/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66830 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66830/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66830 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66830/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66765/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66765 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66765/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66765 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66765/consoleFull)**
for PR 15408 at commit
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/15408
jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66749/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66749 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66749/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66749 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66749/consoleFull)**
for PR 15408 at commit
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/15408
@rxin, @srowen, @mridulm - The consensus seems to be to treat -1 (or less
than 0) as end of file and return value of 0 to continue reading the file
further, I will make the necessary changes.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66714/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66714/consoleFull)**
for PR 15408 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15408
Yea pooling can make sense, but we don't do it anywhere right now so it'd
make more sense to defer until we have a plan to do it more broadly.
---
If your project is set up for it, you can reply to
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/15408
Barring query to @rxin (regarding buffer pooling), I am fine with the
change - pretty neat, thanks @sitalkedia !
Would be good if more eyeballs look at it though given how fundamental it
is.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66714/consoleFull)**
for PR 15408 at commit
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/15408
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66696/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66696/consoleFull)**
for PR 15408 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66696/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66695/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66695/
Test FAILed.
---
Github user sitalkedia commented on the issue:
https://github.com/apache/spark/pull/15408
>> BufferedInputStream supports mark/reset, while we are not doing so here
- does deserialization and other codepaths depend on this ? (If not for
functionality, then for performance ?)
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66695/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66674/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66674 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66674/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66671/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66671 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66671/consoleFull)**
for PR 15408 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66670/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15408
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66670 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66670/consoleFull)**
for PR 15408 at commit
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/15408
There is a behavioral change with this PR, which I am not sure is relevant.
BufferedInputStream supports mark/reset, while we are not doing so here -
does deserialization and other codepaths
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15408
This is pretty low level change that requires more scrutiny, because a bug
here will be very difficult to debug.
cc @zsxwing too since he's one of the most detailed oriented reviewer I
know!
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15408
**[Test build #66674 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66674/consoleFull)**
for PR 15408 at commit
66 matches
Mail list logo
