[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15432 Merged to master/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68201/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68201/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68201/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68196/ Test FAILed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68196/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68196/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68185/ Test FAILed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68185/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Thanks @gatorsmile! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68185/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 LGTM except a few minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68115/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68115/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68109/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68109/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68115/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68108/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68108/ Test FAILed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68109/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68108/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 I will rebase and clean up this tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 I definitely will. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-24 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15432 I assume this will proceed after https://github.com/apache/spark/pull/15513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67047/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67047/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67047/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67046/ Test FAILed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67046/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 @srowen Previously, I also assumed Spark SQL is following the behaviors defined by Hive. However, we already merged a few PRs in Spark SQL that do not follow Hive. Especially, Hive has so many

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67044/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67044/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67043/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67043 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67043/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67046/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Documentation is printed as below now: ```sql spark-sql> DESCRIBE FUNCTION EXTENDED RAND; Function: rand Class: org.apache.spark.sql.catalyst.expressions.Rand Usage:

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67044/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67043/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15432 @gatorsmile @HyukjinKwon As a general comment Spark SQL doesn't claim a particular level of ANSI SQL compatibility. If anything it tries to match "whatever Hive does" and that's probably the best

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67031/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67031/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67030/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67030/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67031/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #67030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67030/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Added `extend` is printed as below: ```sql spark-sql> DESCRIBE FUNCTION EXTENDED rand; Function: rand Class: org.apache.spark.sql.catalyst.expressions.Rand Usage: rand(a)

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 I see. That makes perfect sense in general. It is good to improve test coverage. Though, we might have to avoid adding test cases here and there when there are obviously no side-effect. Running

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Regarding the test cases of R and PythonR, I am fine if you do not add them into the code base. However, please at least run them manually. We hit many surprise bugs in the past just because

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 One more suggestion to your future PR. Whenever you submit a PR, please try to improve the test case coverage. This can help you find bugs in your codes and also benefit the whole community.

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Here, I am talking about the black box testing. If you add the new capability to any external function, you should add it in the test cases. This is very fundamental when we developing

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 I didn't understand. I would like to be very sure on this to avoid mistakes in my future PRs. > the current change in this PR also allows `rand` to take an expression that returns a

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Like what I mentioned above, the current change in this PR also allows `rand` to take an expression that returns a value of a built-in integer/long data type. Thus, you also need to test them

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 @gatorsmile Thanks. I intended to not describe this behaviour first but just thought it'd be kind of handling exceptional cases and it's discouraged because Hive, MySQL and PostgreSQL at least

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 @HyukjinKwon Could you document the behavior in the description of `rand` function? Checked whether we have any missing test case? Not sure whether you are also can check whether `rand` in R and

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15432 Given different databases diverge (they don't even have the same function names), I think it's fine to just have null be treated as 0 like Hive/MySQL. --- If your project is set up for it, you can

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Oh, strictly, it does not ignore in case of `PostgreSQL`. It unsets. ```sql postgres=# SELECT setseed(0); setseed - (1 row) postgres=# SELECT

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Now, at least we have four options, when users setting `NULL` as a seed number for `rand`: 1. Hive/MySQL - `NULL` is equivalent to `0` 2. DB2 - when the seed is `NULL`, `rand` returns

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Ah, PostgreSQL seems unsetting the seed. ``` postgres=# SELECT setseed(0), random(), random(); setseed | random | random

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 What is the behavior of `PostgreSQL`? Treating `NULL` as zero? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Not urgent but in my experience such PR have been being hold. So, I am trying to fix the problem specified in the JIRA only rather than fixing others together. @srowen said "I'm not

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 At first, we do not strictly follow Hive. You can easily find many in Spark. I do not think this is an urgent JIRA, right? Like what @srowen replied in the JIRA, he does not think this is a bug.

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Strictly, the JIRA describes handling `null` and we might not have to generalize the cases further. > it will failed when do select rand(null) Also, I would like to add the

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Unfortunately, not all the things have a standard to follow. That is why I suggested you to do a research about it. Like Oracle, it does not have such a function in their SQL-function list:

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Initially, this JIRA was only handling `null` as seed. If you both worry the change here, I would like to make the PR smaller as suggested initially. --- If your project is set up for it, you

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 That is a great reference. However, is this the function described in a standard? I guess it is different for each implementation of database. For example, > The result can be null;

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Let me show you an example: https://www.ibm.com/support/knowledgecenter/SSEPEK_11.0.0/sqlref/src/tpc/db2z_bif_rand.html This is the official document of `rand` in DB2 z/OS. Below is

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 (Oh, I am making a comment via my phone. Sorry for occasional closing and reopening here..) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 @gatorsmile Thanks for your feedback. Could you please be a little bit specific? Do you expect some researches on the argument of `rand` function in a standard and checking the DBMSs you listed

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 I have a very general comment about the work you are working. Like what we are doing for the `LIKE` operation, we did an investigation on ANSI standard, and all the mainstream data stores,

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 @rxin How does it look like? Let me add some cases for constant folding as @gatorsmile has shown, `RAND(CAST(2 AS INT))` and `CAST(NULL AS INT)` too if it looks okay. --- If your project is

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 I should have added `[WIP]` maybe. If it look okay in general, I will try to follow your suggestions and also the case you gave. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 @gatorsmile Yes (for https://github.com/apache/spark/pull/15432#issuecomment-253291901), it is and sure, I should add more tests. I actually intended to show how it looks like. --- If your

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Since you are running mysql, the output of rand(0) is the same as rand(null)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Not sure whether you realize it. Since this PR changes the input parm of `Rand` and `Randn`, you also changes the external support. Now, users can do something like ```SQL

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 FWIW, the cases below are fine in MySQL: ```sql mysql> SELECT RAND(CAST(2 AS UNSIGNED)); +---+ | RAND(CAST(2 AS UNSIGNED)) |

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66821/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #66821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66821/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #66821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66821/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Oh, my bad. Will fix it up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66815/ Test FAILed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #66815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66815/consoleFull)** for PR 15432 at commit

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 @rxin, I updated the codes and also updated the PR description. Could you please check if my change makes sense? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #66815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66815/consoleFull)** for PR 15432 at commit

  1   2   >