[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-29 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15877 Hey guys - after looking at the pr more, I'm afraid we have gone overboard with testing here. Most of the test cases written are just repeating each other and doing exactly the same thing. For testing

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-29 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15877 Thanks - I'm going to merge this in master. I will submit a follow-up PR to simplify this a little bit, and remove the handling of float/double/decimal types and require explicit user action on how to

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69047/ Test PASSed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #69047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69047/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69049/ Test FAILed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #69049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69049/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #69049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69049/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15877 cc @rxin @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #69047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69047/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68994/ Test PASSed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68994/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68985/ Test PASSed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68985/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68994/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68985/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-17 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15877 Hi @hvanhovell @rxin, I've updated this pr, does it look good to you now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68703/ Test PASSed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68703/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68699/ Test PASSed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68699/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68703/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68699/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68666/ Test FAILed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68666 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68666/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68664/ Test PASSed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68664/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68666/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68664/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-15 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15877 yes please register a count_min_sketch and alias cmsketch in FunctionRegistry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68610/ Test PASSed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68610/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68610/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-14 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15877 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15877 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68604/ Test FAILed. ---

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68604/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15877 cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15877 **[Test build #68604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68604/consoleFull)** for PR 15877 at commit

[GitHub] spark issue #15877: [SPARK-18429] [SQL] implement a new Aggregate for CountM...

2016-11-13 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/15877 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the