Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16441
Indeed re-adding the constructor seems to make the binary compatibility
tests pass (see spark QA build above). I think in favor of making the binary
compat tests pass, we can keep the extra
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70982/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70982 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70982/testReport)**
for PR 16441 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70982 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70982/testReport)**
for PR 16441 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16441
It looks like I am failing the binary compatibility tests despite this
constructor being private:
class GBTClassificationModel private[ml](
@Since("1.6.0") override val uid:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70963 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70963/testReport)**
for PR 16441 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70963/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70963 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70963/testReport)**
for PR 16441 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16441
@sethah @jkbradley thank you for the review - could you please take another
look since I've updated the code review based on your comments?
---
If your project is set up for it, you can
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16441
@jkbradley I've updated based on your comments, please take another look,
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70939/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70939/testReport)**
for PR 16441 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70938/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70938 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70938/testReport)**
for PR 16441 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70939/testReport)**
for PR 16441 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16441
Thanks, I've updated the PR based on your comment. The only disadvantage
to the current code is that I do the probability computation within the
classifier, but it seems like it should be
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70938 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70938/testReport)**
for PR 16441 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70935/testReport)**
for PR 16441 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70935/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70935 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70935/testReport)**
for PR 16441 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16441
Thanks for the PR; I do want to get this fixed. However, I don't think
this is the right way to make predictions of probabilities for GBTs. I believe
it should depend on the loss used. E.g.,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70760/testReport)**
for PR 16441 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70760/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70760/testReport)**
for PR 16441 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16441
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70759/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70759/testReport)**
for PR 16441 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16441
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16441
**[Test build #70759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70759/testReport)**
for PR 16441 at commit
35 matches
Mail list logo
