Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18488
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #3898 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3898/testReport)**
for PR 18488 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #3898 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3898/testReport)**
for PR 18488 at commit
Github user mike0sv commented on the issue:
https://github.com/apache/spark/pull/18488
Found this in janino documentation, it explains the need for explicit
casting: "Type arguments: Are parsed, but otherwise ignored. The most
significant restriction that follows is that you must
Github user mike0sv commented on the issue:
https://github.com/apache/spark/pull/18488
@srowen you are right, we store string values of constant names (for test
example, we would get A and B values, not google/elgoog)
I commented some of the changes for clarity, but I don't see
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18488
I don't feel especially qualified to review this, and I'm hesitant because
I know the core encoder/decoder framework is an important piece that needs some
care.
Your change looks good
Github user mike0sv commented on the issue:
https://github.com/apache/spark/pull/18488
@srowen @HyukjinKwon what's your status on this? anything else I can do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80700/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80700/testReport)**
for PR 18488 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80700/testReport)**
for PR 18488 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18488
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user mike0sv commented on the issue:
https://github.com/apache/spark/pull/18488
@srowen @HyukjinKwon , retest this please :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80685/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80685/testReport)**
for PR 18488 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80685/testReport)**
for PR 18488 at commit
Github user mike0sv commented on the issue:
https://github.com/apache/spark/pull/18488
@srowen @HyukjinKwon it seems like it's all ok now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80489/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80489 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80489/testReport)**
for PR 18488 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80489 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80489/testReport)**
for PR 18488 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18488
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user mike0sv commented on the issue:
https://github.com/apache/spark/pull/18488
@srowen @HyukjinKwon hey guys, I think i got this, take a look. some sparkr
tests failed for some reason, but I think it's not my fault =|
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80457/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80457 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80457/testReport)**
for PR 18488 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80457 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80457/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80456 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80456/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80456/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80456 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80456/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80455/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80455 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80455/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80455 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80455/testReport)**
for PR 18488 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80454 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80454/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80454/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80454 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80454/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80342/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80342/testReport)**
for PR 18488 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80342 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80342/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80166 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80166/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80166/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80166 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80166/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80163 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80163/testReport)**
for PR 18488 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80163/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #80163 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80163/testReport)**
for PR 18488 at commit
Github user mike0sv commented on the issue:
https://github.com/apache/spark/pull/18488
Ran into something strange. Changed ints to strings and it worked fine. But
then I added a test for encoding bean with enum inside and the test failed. It
failed because in my implementation
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18488
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79105/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18488
**[Test build #79105 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79105/testReport)**
for PR 18488 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18488
I see, so the bean encoder assumes every property is a bean.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mike0sv commented on the issue:
https://github.com/apache/spark/pull/18488
It won't work if I have enum field inside regular java bean.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18488
How about just using Encoders.javaSerialization() with enums?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
59 matches
Mail list logo
