Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18810
ok, I'll make a pr as follow-up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18810
Thank you for tracking it! Could you adjust the conf to a higher number
(e.g. 4097)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18810
Btw, as for merged prs, I'm just monitoring TPCDS perf. in
[here](https://docs.google.com/spreadsheets/d/1V8xoKR9ElU-rOXMH84gb5BbLEw0XAPTJY8c8aZeIqus/edit#gid=445143188).
Also, I wrote a script
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18810
yea, I'll do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18810
@maropu Interesting. Would you like to benchmark with #18931 too? It is my
attempt to solve long code-gen functions without disabling it.
---
If your project is set up for it, you can reply to this
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18810
(copied from jira for just-in-case) Just for your information, I checked
the performance changes of TPCDS before/after the pr #18810; the pr affected
Q17/Q66 only (that is, they have too long
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18810
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18810
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80703/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80703 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80703/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80703/testReport)**
for PR 18810 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18810
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18810
Thank you for your contribution! Due to the impact of this PR, we need to
be more cautious. Trying to get more feedbacks from the others.
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80564/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80564 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80564/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80563/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80563 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80563/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80564 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80564/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80563 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80563/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80537/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80537 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80537/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80537 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80537/testReport)**
for PR 18810 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18810
@cloud-fan I am thinking about how we can split a super long function into
multiple function as `CodeGenerator.splitExpressions` does.
---
If your project is set up for it, you can reply to this
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18810
@cloud-fan This is a right direction we should work. This change can be a
base used to check if we generate super long functions. Once we are confident
that whole stage codegen framework is
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18810
shall we improve the whole stage codegen framework and avoid generating
super long functions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80522/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80522 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80522/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80518 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80518/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80522 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80522/testReport)**
for PR 18810 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18810
LGTM except for few comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80518 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80518/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80516/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80516/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80516/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80488/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80488 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80488/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80488/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80481/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80481 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80481/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80481 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80481/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80475/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80475/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80476/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80476/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80476/testReport)**
for PR 18810 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18810
Btw, can you change `[sql]` to `[SQL]` in title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80475/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80472/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80472 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80472/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80471/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80471 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80471/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80470/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80470 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80470/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80472 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80472/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80471 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80471/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80470/testReport)**
for PR 18810 at commit
Github user eatoncys commented on the issue:
https://github.com/apache/spark/pull/18810
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80329/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80329/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80326/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80326/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80329/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80326 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80326/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80325/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80325/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80325 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80325/testReport)**
for PR 18810 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80318/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80318 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80318/testReport)**
for PR 18810 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18810
**[Test build #80318 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80318/testReport)**
for PR 18810 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18810
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18810
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
89 matches
Mail list logo
