Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82128 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82128/testReport)**
for PR 19290 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19290
oh, remember to remove WIP and update this line
https://github.com/apache/spark/pull/19290/files#diff-74ca2b618d236bbd6faa23e13bff1403R30
before merging in?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82120/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82120 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82120/testReport)**
for PR 19290 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82120/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
I also tried v1.0.1 against the master; however, it looks not detecting
many instances this PR fixes. It only detected 3 extra instances:
```
R/DataFrame.R:2615:22: style: Variable
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
> 5 min: this is mildly concerning, is it possible this is caused by new
checks in lintr? perhaps we could exclude them or something?
1.0.1 miss the linters below (vs master):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
> anyway I mean if we use the git tag 9951084 it should match v1.0.1
release exactly.
the one you listed jimhester/lintr@5431140 is in master I think and perhaps
you are saying there are
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
Will update the comment tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82081 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82081/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
I initially did this, for example,
```
\href{https://spark.apache.org/docs/latest/sparkr.html#data-type-mapping-between-
r-and-spark}{Spark Data Types} for available data types.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
Doh, you mean the current status. Yes, I checked.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19290
btw, could you check if haven't already, if `nolint` around the `http`
link, roxygen is going to handle that correctly?
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19290
isn't it the other way around?
https://github.com/jimhester/lintr/compare/v1.0.1?expand=1
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82034/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82034/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
To @shivaram:
> does that also happen with lintr-1.0.1 ? I wonder if we are seeing some
specific performance slowdown because of not using a release (it might be good
to follow up with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82034/testReport)**
for PR 19290 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19290
I think this is great to have, thanks for solving the mystery.
- 5 min: this is mildly concerning, is it possible this is caused by new
checks in lintr? perhaps we could exclude them or
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/19290
@HyukjinKwon Thanks for looking at this. The 5 min addition seems
unfortunate though -- does that also happen with lintr-1.0.1 ? I wonder if we
are seeing some specific performance slowdown
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82000/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82000 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82000/testReport)**
for PR 19290 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82000 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82000/testReport)**
for PR 19290 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81988/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #81988 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81988/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
@felixcheung and @shivaram,
Should we upgrade this to the latest commit? it increases the time by 5ish
mins.
If there is any worry about upgrading, I am willing to leave the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #81988 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81988/testReport)**
for PR 19290 at commit
32 matches
Mail list logo
