Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85146/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85146/testReport)**
for PR 20015 at commit
[`238d7d4`](https://github.com/apache/spark/commit/2
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20015
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.ap
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20015
Thanks! Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: r
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85141/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85141 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85141/testReport)**
for PR 20015 at commit
[`0d1a8cb`](https://github.com/apache/spark/commit/0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85146/testReport)**
for PR 20015 at commit
[`238d7d4`](https://github.com/apache/spark/commit/23
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85145/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85140/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85140 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85140/testReport)**
for PR 20015 at commit
[`80a1959`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85141 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85141/testReport)**
for PR 20015 at commit
[`0d1a8cb`](https://github.com/apache/spark/commit/0d
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85140 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85140/testReport)**
for PR 20015 at commit
[`80a1959`](https://github.com/apache/spark/commit/80
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85132/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85132 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85132/testReport)**
for PR 20015 at commit
[`b12ba92`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85131/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85131 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85131/testReport)**
for PR 20015 at commit
[`3547b7c`](https://github.com/apache/spark/commit/3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85132 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85132/testReport)**
for PR 20015 at commit
[`b12ba92`](https://github.com/apache/spark/commit/b1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85131 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85131/testReport)**
for PR 20015 at commit
[`3547b7c`](https://github.com/apache/spark/commit/35
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20015
- The API proposed by this PR is consistent with the other DBs.
- The implementation does not introduce the behavior changes.
The implementation is clean and the PR quality is pretty
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20015
SPARK-17174 originally described few functions related with hour, min, etc.
but I received an advice to fix up other related functions too even though they
could also be done alone too. I agreed
Github user youngbink commented on the issue:
https://github.com/apache/spark/pull/20015
hmm...even if we decide to change this later, I honestly think merging
`trunc` and `date_trunc` would be a simple work that only touches a couple of
files, mostly in `datetimeExpressions.scala`.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20015
I get `date_trunc` is common in other DBMS. I can see that this can be done
now and we can still proceed `trunc`, etc. later. So, I am fine but still less
sure tho.
---
--
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20015
If we haven't get a similar function, I would have gone +1 but what I am
less sure is `date_trunc` actually quite sounds a better version of `trunc` to
be honest. Seems both also extend the same
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20015
We had an offline discussion and wanna send this out to get more feedbacks.
So generally just adding `date_trunc` is pretty straightforward and makes Spark
consistent with other databases about th
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20015
Yeah keep any substantive discussion on the public lists. Sometimes a side
conversation happens; summarize the points here.
We've rejected a lot of other functions that other DBs, but not Hiv
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20015
OK. I am fine if you all guys strongly feel about this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Fo
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85083/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20015
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20015
**[Test build #85083 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85083/testReport)**
for PR 20015 at commit
[`f94f401`](https://github.com/apache/spark/commit/f
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20015
> after having a discussion with @cloud-fan, @gatorsmile, @rednaxelafx and
Reynold
Where did the discussion happen? Was this offline discussion? I also want
to actively join in the disc
Github user youngbink commented on the issue:
https://github.com/apache/spark/pull/20015
@HyukjinKwon Just took a look at this PR #14788.
My point of mentioning those databases was just to give examples of the
function that Spark doesn't support but other databases commonly
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20015
@cloud-fan and @youngbink how about reviving
https://github.com/apache/spark/pull/14788 with a configuration to control this?
AWS Redshift seems having `TRUNC` which just converts a time
38 matches
Mail list logo
