Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20641
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20641
yap, that sounds like a good idea
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user krcz commented on the issue:
https://github.com/apache/spark/pull/20641
@felixcheung It fixes the same problem so in terms of implementation it is
not very different. But when I created this one 21014 didn't exist.
The only difference is that this PR adds an unit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20641
@krcz how is your PR different from 21014?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixb commented on the issue:
https://github.com/apache/spark/pull/20641
@krcz
@felixcheung <- different felix ;)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user krcz commented on the issue:
https://github.com/apache/spark/pull/20641
@felixb @skonto
I've triend rebasing, but it looks that the issue has been meanwhile fixed
independently in [other pull
request](https://github.com/apache/spark/pull/21014) while someone was
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20641
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91820/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20641
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20641
**[Test build #91820 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91820/testReport)**
for PR 20641 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20641
**[Test build #91820 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91820/testReport)**
for PR 20641 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20641
@mgummelt too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20641
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20641
ok, could you rebase this PR
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20641
@skonto Thanks for testing it. Tests results look good.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/20641
@krcz yes it should be ok. So I verified it:
Dispatcher passes the following command to mesos:
```18/06/13 10:30:45 INFO MesosClusterScheduler: Command for the driver
Github user krcz commented on the issue:
https://github.com/apache/spark/pull/20641
@skonto The one directly below "At the driver side in DC/OS:" in your
comment. But if it's output of ps that's ok, as `ps` wouldn't be able to
discern between `command "foo bar"` and `command foo
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/20641
@krcz which one? Btw both job run successfully although might not have been
escaped properly.
---
-
To unsubscribe, e-mail:
Github user krcz commented on the issue:
https://github.com/apache/spark/pull/20641
@skonto
The command you have pasted as "At the driver side in DC/OS:" concerns me.
It doesn't seem escaped properly. Is it the command to be run by shell or is
it just space-joined arguments
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/20641
@susanxhuynh I tested this. Here is what you get:
```
./bin/spark-submit --deploy-mode cluster --name test --master
mesos://spark.marathon.mesos:13830 --driver-cores 1.0 --driver-memory
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20641
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user krcz commented on the issue:
https://github.com/apache/spark/pull/20641
@susanxhuynh Thanks for the example! I have added similar test, covering
more cases. After you or someone else reviews it, I'll rebase the pull request.
---
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/20641
Thanks for the PR! It seems that the previous attempt to fix this
(SPARK-18114) was wrong -- I'm not sure why we didn't catch the problem before,
maybe lack of testing? @krcz My suggestion for
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20641
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20641
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
24 matches
Mail list logo
