[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-87954124 /cc @aarondav and @rxin, with whom I discussed some of the existing design. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5286#discussion_r27455173 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -439,14 +439,10 @@ private[spark] class BlockManager( // As an

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-87956528 We have to put that whenever we don't create a JIRA or else the scripts we use get messed up. I can just make a JIRA for the overall clean-up. --- If your project is

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-87954690 [Test build #29456 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29456/consoleFull) for PR 5286 at commit

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-87954350 [Test build #29456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29456/consoleFull) for PR 5286 at commit

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5286#discussion_r27454958 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -439,14 +439,10 @@ private[spark] class BlockManager( // As an

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5286#discussion_r27454970 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -439,14 +439,10 @@ private[spark] class BlockManager( // As an

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-87954699 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-87955385 Why is this a HOTFIX? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

GitHub user pwendell opened a pull request: https://github.com/apache/spark/pull/5286 [HOTFIX] Some clean-up in shuffle code. Before diving into review #4450 I did a look through the existing shuffle code to learn how it works. Unfortunately, there are some very confusing

[GitHub] spark pull request: [HOTFIX] Some clean-up in shuffle code.

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5286#issuecomment-87956681 At a high level LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this