Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-140354078
@jkbradley OK, I will send a follow-up PR to add some comments to the
cacheNodeIds doc ASAP.
---
If your project is set up for it, you can reply to this email and
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8528#discussion_r39293299
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -56,7 +56,8 @@ private[shared] object SharedParamsCodeGen
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-139605519
> I think we need to have some more discussion about whether this change is
appropriate. I think the rationale for not including in sharedParams was to
hide the
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8528
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-139444354
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8528#discussion_r38449868
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -56,7 +56,8 @@ private[shared] object SharedParamsCodeGen {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136567545
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136567532
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8528#discussion_r38364524
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -96,23 +96,8 @@ private[ml] trait DecisionTreeParams extends
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136513283
To enable checkpointing you also need to set the `cacheNodeIds` param so
that should be modified as well.
I think we need to have some more discussion
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8528#discussion_r38370607
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -56,7 +56,8 @@ private[shared] object SharedParamsCodeGen {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136320825
[Test build #41821 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41821/consoleFull)
for PR 8528 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136329752
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136318476
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136318495
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136329682
[Test build #41821 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41821/console)
for PR 8528 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136329753
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136582072
[Test build #41853 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41853/console)
for PR 8528 at commit
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8528#discussion_r38381939
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -96,23 +96,8 @@ private[ml] trait DecisionTreeParams extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136568186
[Test build #41853 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41853/consoleFull)
for PR 8528 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136582143
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136582142
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136125397
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136161239
[Test build #41807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41807/consoleFull)
for PR 8528 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136162323
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136162324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/8528
[SPARK-10023] [ML] [PySpark] Unified DecisionTreeParams checkpointInterval
between Scala and Python API.
checkpointInterval is member of DecisionTreeParams in Scala API which is
inconsistency
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136162275
[Test build #41807 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41807/console)
for PR 8528 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8528#issuecomment-136160643
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
29 matches
Mail list logo
