[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151389719 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151389533 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151411865 **[Test build #44410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44410/consoleFull)** for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151411970 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151411969 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151391381 **[Test build #44410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44410/consoleFull)** for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8652 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151707727 @yhuai Any more comment on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151710285 LGTM. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42961980 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -321,6 +320,21 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151056814 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151056815 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42962007 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala --- @@ -44,8 +44,9 @@ class SparkPlanner(val sqlContext:

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151034668 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151034684 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151034717 Thank you @yhuai , I've just split the `BroadcastNestedLoopJoin` into `BroadcastNestedLoop` and `DefaultJoin`, which probably makes more sense. --- If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42961928 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -294,25 +294,24 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151056724 **[Test build #44341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44341/consoleFull)** for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151035354 **[Test build #44341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44341/consoleFull)** for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42954743 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,27 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151009666 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151009673 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42957158 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -295,8 +295,21 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42957141 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala --- @@ -44,8 +44,7 @@ class SparkPlanner(val sqlContext:

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42958162 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala --- @@ -44,8 +44,7 @@ class SparkPlanner(val sqlContext: SQLContext)

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151008847 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42956963 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala --- @@ -44,8 +44,7 @@ class SparkPlanner(val sqlContext: SQLContext)

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151008850 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42960365 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala --- @@ -44,8 +44,7 @@ class SparkPlanner(val sqlContext:

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42956996 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -295,8 +295,21 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42957003 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -295,8 +295,21 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151009269 **[Test build #44329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44329/consoleFull)** for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151012848 **[Test build #44331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44331/consoleFull)** for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151026598 **[Test build #44329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44329/consoleFull)** for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151026650 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151026651 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151027985 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151027921 **[Test build #44331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44331/consoleFull)** for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151027984 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42960791 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -295,8 +295,21 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42961328 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala --- @@ -44,8 +44,7 @@ class SparkPlanner(val sqlContext: SQLContext)

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42961354 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala --- @@ -44,8 +44,7 @@ class SparkPlanner(val sqlContext: SQLContext)

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42893820 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,27 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42893851 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,27 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-22 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-150343974 /cc @harsha2010, this PR may interest you given your similar broadcast cartesian join optimizations in Magellan. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-19 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42439820 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,27 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-19 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42446830 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,27 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-149086027 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-149086029 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-149072159 [Test build #43906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43906/consoleFull) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-149085966 [Test build #43906 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43906/console) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-18 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-149070550 Thank you @liancheng updated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-149070584 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-149070588 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42272078 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -69,6 +71,58 @@ class HiveQuerySuite extends

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42272209 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HivePlanTest.scala --- @@ -17,6 +17,7 @@ package

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42272725 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -69,6 +71,58 @@ class HiveQuerySuite extends

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42286218 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,27 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42286246 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,27 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-16 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42286382 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -69,6 +71,58 @@ class HiveQuerySuite extends

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148305056 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148305081 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148310064 [Test build #43775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43775/console) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148310086 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148310087 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148315435 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148315405 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148305296 @yhuai, after some investigation, I think the we still can optimize the left/right/full outer join in broadcasting way if they don't have condition, but LeftSemi

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148315153 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148306268 [Test build #43775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43775/consoleFull) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148320732 [Test build #43779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43779/console) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148320814 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148320815 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148316845 [Test build #43779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43779/consoleFull) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148582817 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148582815 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148582755 [Test build #43820 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43820/console) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148560925 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148560912 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148561331 [Test build #43820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43820/consoleFull) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42017603 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,12 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148271780 [Test build #43763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43763/consoleFull) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42078997 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,12 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42079119 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,12 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r42079174 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,12 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148271135 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148271097 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148286123 [Test build #43763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43763/console) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148286224 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-148286221 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-13 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r41954346 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,12 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-13 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8652#discussion_r41954109 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -268,6 +268,12 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-09-24 Thread jameszhouyi
Github user jameszhouyi commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-142917749 Hi @yhuai , I saw the PR is ready for some time. could you help to review this PR. Hopefully it can be fixed in 1.5.1. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-138465820 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-138465777 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-09-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-138467535 [Test build #42126 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42126/consoleFull) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-09-08 Thread chenghao-intel
GitHub user chenghao-intel opened a pull request: https://github.com/apache/spark/pull/8652 [SPARK-10484][SQL] Optimize the cartesian join with broadcast join for some cases In some cases, we can broadcast the smaller relation in cartesian join, which improve the performance

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-09-08 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-138510593 Looks this is a part of #7417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-09-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-138500699 [Test build #42126 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42126/console) for PR 8652 at commit

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-09-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-138500846 Test PASSed. Refer to this link for build results (access rights to CI server needed):

  1   2   >