[GitHub] spark pull request: [SPARK-10757] [MLlib] Java friendly constructo...

2015-10-27 Thread javelinjs
Github user javelinjs commented on the pull request: https://github.com/apache/spark/pull/9159#issuecomment-151532262 @yanboliang @mengxr I've added some test cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-10757] [MLlib] Java friendly constructo...

2015-10-26 Thread javelinjs
Github user javelinjs commented on the pull request: https://github.com/apache/spark/pull/9159#issuecomment-151049530 @yanboliang Your constructor can build. But this implies exposing ```[M <: Matrix]``` to users, we will see something like ```bm: BlockMatrix[SparseMatrix]``` here

[GitHub] spark pull request: [SPARK-10757] [MLlib] Java friendly constructo...

2015-10-26 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/9159#issuecomment-151034714 @mengxr Could you add @javelinjs to whitelist? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-10757] [MLlib] Java friendly constructo...

2015-10-26 Thread javelinjs
Github user javelinjs commented on the pull request: https://github.com/apache/spark/pull/9159#issuecomment-151035109 @yanboliang Sure I'll work on it soon. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-10757] [MLlib] Java friendly constructo...

2015-10-26 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/9159#issuecomment-151034920 @javelinjs Could you add unit test cases for this function? Then Jenkins could run tests for you patch after @mengxr added you to whitelist. --- If your project is

[GitHub] spark pull request: [SPARK-10757] [MLlib] Java friendly constructo...

2015-10-18 Thread javelinjs
GitHub user javelinjs opened a pull request: https://github.com/apache/spark/pull/9159 [SPARK-10757] [MLlib] Java friendly constructor for distributed matrices This patch allows java developers to construct BlockMatrix and RowMatrix more naturally. Take BlockMatrix as an

[GitHub] spark pull request: [SPARK-10757] [MLlib] Java friendly constructo...

2015-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9159#issuecomment-149007620 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your