[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-148118184 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-148118125 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-148121320 [Test build #43723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43723/consoleFull) for PR 9112 at commit

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-147959050 [Test build #43706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43706/consoleFull) for PR 9112 at commit

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-147957640 cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/9112 [SPARK-11096] Post-hoc review Netty based RPC implementation - round 2 A few more changes: 1. Renamed IDVerifier -> RpcEndpointVerifier 2. Renamed NettyRpcAddress -> RpcEndpointAddress

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9112#discussion_r41960959 --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala --- @@ -94,15 +94,6 @@ private[spark] abstract class RpcEnv(conf: SparkConf) { }

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9112#discussion_r41961012 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -406,49 +409,37 @@ private[netty] class NettyRpcHandler( private type

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-147958017 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-147957976 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/9112#discussion_r41962323 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -406,49 +409,37 @@ private[netty] class NettyRpcHandler( private

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-147961261 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-147982861 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-147982862 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-147982772 [Test build #43706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43706/console) for PR 9112 at commit

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-148167054 [Test build #43723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43723/console) for PR 9112 at commit

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-148167368 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-148167373 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-148171964 Merging this . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11096] Post-hoc review Netty based RPC ...

2015-10-14 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9112#issuecomment-148059833 Oh, `NettyRpcHandlerSuite.receive` tests the case that a remote client fires multiple connections. You can remove L45 and L46 here: