Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149587427
@vundela Does SPARK_LOG4J_CONF still work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vundela commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42503914
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -497,6 +497,19 @@ private[spark] class Client(
*/
private def
Github user vundela commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149588730
@tgravescs Yes, it still works and user see a deprecated message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42503542
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -497,6 +497,19 @@ private[spark] class Client(
*/
private def
Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149644490
I have one more noob question. Let's say I have a 4 node hadoop/yarn
cluster and a 5th node, I am driving a yarn-client app from. I use puppet to
set up my log4j
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149657635
Got it, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149651459
@markgrover you can't have that scenario on YARN because when running Spark
through YARN there is no "cluster configuration". Everything is configured
based on the
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149608519
changes lgtm. @vanzin are you ok with these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149257321
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149259270
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149259241
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149260451
**[Test build #43929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43929/consoleFull)**
for PR 9118 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149257320
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149257322
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149257298
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149309256
This isn't really a but as it was kind of designed this way. Originally
you had to either set SPARK_LOG4J_CONF (which does SPARK_LOG4J_CONF still work
properly?)
Github user vundela commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149328542
@tgravescs
Thanks for the review. Yes, it make sense to update the documentation.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149377264
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149377247
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149363556
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149364898
**[Test build #43943 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43943/consoleFull)**
for PR 9118 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149367985
**[Test build #43943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43943/consoleFull)**
for PR 9118 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149381570
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42434651
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -497,6 +497,20 @@ private[spark] class Client(
*/
private def
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42434676
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -497,6 +497,20 @@ private[spark] class Client(
*/
private def
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149377726
**[Test build #43952 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43952/consoleFull)**
for PR 9118 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149363592
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149368037
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149368032
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149381336
**[Test build #43952 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43952/consoleFull)**
for PR 9118 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149381572
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149401211
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149401495
**[Test build #43958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43958/consoleFull)**
for PR 9118 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149407006
**[Test build #43958 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43958/consoleFull)**
for PR 9118 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149407072
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149407073
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42446420
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -497,6 +497,19 @@ private[spark] class Client(
*/
private def
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149401196
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149272877
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149272263
**[Test build #43929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43929/consoleFull)**
for PR 9118 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-149272876
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42135926
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148409085
LGTM too, the tests seem to have passed as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148443924
So, I thought about this a little bit more and I think it would be worth it
to put that file in `createConfArchive` instead. That way, it's more efficient,
since it's
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42146188
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148163198
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42042756
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user vundela commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42043365
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42047771
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42049285
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user vundela commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148163495
@vanzin can you please review the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42042421
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42042383
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user vundela commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42043343
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
GitHub user vundela opened a pull request:
https://github.com/apache/spark/pull/9118
[SPARK-11105][yarn] Distribute log4j.properties to executors
Currently log4j.properties file is not uploaded to executor's which is
leading them to use the default values. This fix will make sure
Github user vundela commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42043730
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user vundela commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42058235
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user vundela commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42058190
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,14 @@ private[spark] class Client(
"for
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42063646
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,15 @@ private[spark] class Client(
"for
Github user vundela commented on a diff in the pull request:
https://github.com/apache/spark/pull/9118#discussion_r42067281
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -340,6 +340,15 @@ private[spark] class Client(
"for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148239448
[Test build #43756 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43756/consoleFull)
for PR 9118 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148242697
[Test build #43756 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43756/console)
for PR 9118 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148238862
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148238885
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148242856
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148242853
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148238683
LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9118#issuecomment-148238617
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
69 matches
Mail list logo
