[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-29 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r43416866 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DatasetHolder.scala --- @@ -0,0 +1,30 @@ +/* +* Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-29 Thread binarybana
Github user binarybana commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r43416475 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DatasetHolder.scala --- @@ -0,0 +1,30 @@ +/* +* Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r43120465 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-27 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r43113163 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r43108962 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42977432 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GroupedIterator.scala --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42970431 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-26 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42970368 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/tuples.scala --- @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42960084 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/tuples.scala --- @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42960493 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150304953 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42780810 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150305783 **[Test build #44162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44162/consoleFull)** for PR 9190 at commit

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42778416 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/Encoder.scala --- @@ -46,13 +47,27 @@ trait Encoder[T] { /**

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150338653 **[Test build #44162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44162/consoleFull)** for PR 9190 at commit

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150338785 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150338781 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42778185 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150305742 Hey Guys, thanks for looking this over! I think I addressed most of your comments, but let me know if you want to talk about anything further. --- If your project is

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42777859 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150304918 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150371978 I'm going to merge this. We should continue to do review post-hoc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-22 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42776824 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedDataset.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150014839 **[Test build #44087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44087/consoleFull)** for PR 9190 at commit

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150013834 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150013863 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150044350 **[Test build #44087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44087/consoleFull)** for PR 9190 at commit

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150044716 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-150044715 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42700923 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -36,6 +38,10 @@ private[sql] object Column { def unapply(col: Column):

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42701186 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -387,6 +389,10 @@ class SQLContext private[sql]( def $(args: Any*):

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42701182 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -21,6 +21,8 @@ import java.beans.{BeanInfo, Introspector} import

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42701621 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/tuples.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42701532 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -17,6 +17,8 @@ package org.apache.spark.sql +import

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42701821 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLImplicits.scala --- @@ -33,6 +37,16 @@ import org.apache.spark.unsafe.types.UTF8String

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42702153 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -17,6 +17,8 @@ package org.apache.spark.sql +import

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42702730 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42702909 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42702840 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42702889 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/Encoder.scala --- @@ -31,6 +31,7 @@ import org.apache.spark.sql.types.StructType

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42702955 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42702965 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -0,0 +1,398 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42702980 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/Encoder.scala --- @@ -46,13 +47,27 @@ trait Encoder[T] { /**

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42703300 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/Encoder.scala --- @@ -46,13 +47,27 @@ trait Encoder[T] { /**

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42703289 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedDataset.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149828370 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149828393 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-14982 **[Test build #44056 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44056/consoleFull)** for PR 9190 at commit

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149859719 **[Test build #44056 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44056/consoleFull)** for PR 9190 at commit

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149859824 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149859825 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149752240 **[Test build #44026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44026/consoleFull)** for PR 9190 at commit

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149750983 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149750967 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9190#discussion_r42575073 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -36,6 +36,10 @@ private[sql] object Column { def unapply(col: Column):

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-20 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/9190 [SPARK-6] [SQL] First Draft of Dataset API *This PR adds a new experimental API to Spark, tentitively named Datasets.* A `Dataset` is a strongly typed collection of objects that can be

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149770955 **[Test build #44026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44026/consoleFull)** for PR 9190 at commit

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149771016 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11116] [SQL] First Draft of Dataset API

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9190#issuecomment-149771015 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your