Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204586323
@mengxr @feynmanliang Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204274118
LGTM. Merged into master. Thanks and sorry for the long delay in code
review!
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204193466
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204193464
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204193319
**[Test build #54671 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54671/consoleFull)**
for PR 9229 at commit
[`94dcec0`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204155568
**[Test build #54671 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54671/consoleFull)**
for PR 9229 at commit
[`94dcec0`](https://gith
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204155203
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204093644
Build exception unrelated to PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204078763
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204078767
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204078166
**[Test build #54646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54646/consoleFull)**
for PR 9229 at commit
[`94dcec0`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204027722
**[Test build #54646 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54646/consoleFull)**
for PR 9229 at commit
[`94dcec0`](https://gith
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204027014
@mengxr That is a `project/MimaExcludes.scala`. Apparently, it is modified
almost every day in the master branch. Rebased.
---
If your project is set up for it, you ca
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-204011997
@avulanov This PR still has conflicts with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-202592262
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-202592264
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-202591981
**[Test build #54347 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54347/consoleFull)**
for PR 9229 at commit
[`b21b56a`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-202549516
**[Test build #54347 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54347/consoleFull)**
for PR 9229 at commit
[`b21b56a`](https://gith
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-202549016
@mengxr Rebased to accomodate https://github.com/apache/spark/pull/9854
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198131262
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198044655
**[Test build #53461 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53461/consoleFull)**
for PR 9229 at commit
[`e5bef10`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198131203
**[Test build #53461 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53461/consoleFull)**
for PR 9229 at commit
[`e5bef10`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198039863
**[Test build #53459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53459/consoleFull)**
for PR 9229 at commit
[`e4e8c0d`](https://gith
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198116834
@mengxr Could you suggest what would be the best practice to handle zeros
in the computation of logarithm of output?
https://github.com/avulanov/spark/blob/mlp-refactor
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198095363
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198094792
**[Test build #53459 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53459/consoleFull)**
for PR 9229 at commit
[`e4e8c0d`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198095370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198131260
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-198056498
@mengxr Thank you for reviewing! I've addressed all comments, except
- Return mutated parameter instead of `Unit`. I believe that it might be
misleading becau
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-196945850
@avulanov I made one pass on the implementation. Besides inline comments:
* It is good to keep the size checks as safe guards.
* For methods that modify the in
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208098
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait MultilayerPerc
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208163
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -164,11 +208,18 @@ class MultilayerPerceptronCla
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208120
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait MultilayerPerc
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208130
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait MultilayerPerc
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208156
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -141,12 +178,19 @@ class MultilayerPerceptronCla
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208138
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait MultilayerPerc
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208010
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208068
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208142
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait MultilayerPerc
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208108
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait MultilayerPerc
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208078
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208149
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait MultilayerPerc
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207975
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -654,12 +513,19 @@ private[ann] object FeedForwardModel {
def apply(topology: F
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208042
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208020
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208087
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -22,7 +22,8 @@ import scala.collection.JavaConve
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208034
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208014
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208093
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait MultilayerPerc
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208058
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208055
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207992
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -783,6 +649,22 @@ private[ml] class FeedForwardTrainer(
private var optimizer:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207978
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -774,8 +640,8 @@ private[ml] class FeedForwardTrainer(
val inputSize: Int,
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207997
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -783,6 +649,22 @@ private[ml] class FeedForwardTrainer(
private var optimizer:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207987
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -783,6 +649,22 @@ private[ml] class FeedForwardTrainer(
private var optimizer:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207864
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return we
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207952
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -294,89 +248,13 @@ private[ann] object ActivationFunction {
}
/**
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207931
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -150,72 +166,32 @@ private[ann] object AffineLayerModel {
/**
* Creates
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207898
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return we
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207940
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -226,44 +236,21 @@ private[ann] trait ActivationFunction extends
Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207829
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -32,20 +32,43 @@ import org.apache.spark.util.random.XORShiftRandom
*
*/
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207880
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return we
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207844
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -32,20 +32,43 @@ import org.apache.spark.util.random.XORShiftRandom
*
*/
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207904
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -96,50 +112,50 @@ private[ann] trait LayerModel extends Serializable {
*/
p
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207925
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -150,72 +166,32 @@ private[ann] object AffineLayerModel {
/**
* Creates
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207877
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return we
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207888
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return we
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207892
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191456034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191456033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191455649
**[Test build #52334 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52334/consoleFull)**
for PR 9229 at commit
[`3345e6f`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191395838
**[Test build #52334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52334/consoleFull)**
for PR 9229 at commit
[`3345e6f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191381068
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191381070
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191380991
**[Test build #52332 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52332/consoleFull)**
for PR 9229 at commit
[`6385112`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191374553
**[Test build #52332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52332/consoleFull)**
for PR 9229 at commit
[`6385112`](https://gith
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-191374451
@mengxr Thank you! I did rebase and addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-190849301
I made a quick pass on the unit tests. Will check the implementation later
today.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r54613525
--- Diff: mllib/src/test/scala/org/apache/spark/ml/ann/GradientSuite.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r54613519
--- Diff: mllib/src/test/scala/org/apache/spark/ml/ann/GradientSuite.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r54613493
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala
---
@@ -49,7 +49,48 @@ class MultilayerPerceptronC
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r54613504
--- Diff: mllib/src/test/scala/org/apache/spark/ml/ann/GradientSuite.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r54613510
--- Diff: mllib/src/test/scala/org/apache/spark/ml/ann/GradientSuite.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r54613520
--- Diff: mllib/src/test/scala/org/apache/spark/ml/ann/GradientSuite.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r54613528
--- Diff: mllib/src/test/scala/org/apache/spark/ml/ann/GradientSuite.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-157843524
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-157843519
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-157843425
**[Test build #46222 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46222/consoleFull)**
for PR 9229 at commit
[`d000e4e`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-157799251
**[Test build #46222 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46222/consoleFull)**
for PR 9229 at commit
[`d000e4e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-156619003
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-156619004
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-156618939
**[Test build #45915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45915/consoleFull)**
for PR 9229 at commit
[`ae3ea13`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-156605880
**[Test build #45915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45915/consoleFull)**
for PR 9229 at commit
[`ae3ea13`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-155992446
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-155992444
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-155992319
**[Test build #45698 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45698/consoleFull)**
for PR 9229 at commit
[`e3ca7f1`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-155972682
**[Test build #45698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45698/consoleFull)**
for PR 9229 at commit
[`e3ca7f1`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-155971552
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-155971534
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
1 - 100 of 171 matches
Mail list logo
