Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43671708
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1921,4 +1921,89 @@ class SQLQuerySuite extends QueryTest with
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43669656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +168,55 @@ abstract class Star extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43716153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,68 @@ abstract class Star extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43716232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,68 @@ abstract class Star extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153173249
**[Test build #44840 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44840/consoleFull)**
for PR 9343 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153172555
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43689290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +168,55 @@ abstract class Star extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153172474
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153197858
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153197856
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43702827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,63 @@ abstract class Star extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43703147
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,63 @@ abstract class Star extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153197650
**[Test build #44840 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44840/consoleFull)**
for PR 9343 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43703049
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,63 @@ abstract class Star extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43702945
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,63 @@ abstract class Star extends
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43705776
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,63 @@ abstract class Star extends
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43705834
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,63 @@ abstract class Star extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153212674
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153212605
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153213191
**[Test build #44862 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44862/consoleFull)**
for PR 9343 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43715293
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1932,4 +1932,137 @@ class SQLQuerySuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43715351
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1932,4 +1932,137 @@ class SQLQuerySuite extends QueryTest with
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153236010
Thanks @nongli ! Overall LGTM. I am going to merge it to master. Can you
create a follow-up PR to address my comments? Thanks!
---
If your project is set up for it, you
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43715869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -466,9 +466,9 @@ object SqlParser extends AbstractSparkSQLParser
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43715968
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,68 @@ abstract class Star extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43622494
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1921,4 +1921,89 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43622767
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1921,4 +1921,89 @@ class SQLQuerySuite extends QueryTest with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153231716
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153231717
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-153231640
**[Test build #44862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44862/consoleFull)**
for PR 9343 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43586963
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +166,58 @@ abstract class Star extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43586920
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -286,44 +304,42 @@ class Analyzer(
case p @
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43586919
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -286,44 +304,42 @@ class Analyzer(
case p @
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43586981
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +168,55 @@ abstract class Star extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43586989
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +168,55 @@ abstract class Star extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43587089
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1921,4 +1921,89 @@ class SQLQuerySuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43477553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +168,55 @@ abstract class Star extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152650397
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43549569
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -166,26 +168,55 @@ abstract class Star extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152671830
**[Test build #44704 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44704/consoleFull)**
for PR 9343 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152650374
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152652356
**[Test build #44704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44704/consoleFull)**
for PR 9343 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152671936
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152671938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43470847
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1870,4 +1870,66 @@ class SQLQuerySuite extends QueryTest with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152053435
**[Test build #44555 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44555/consoleFull)**
for PR 9343 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152053526
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152053527
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9343#discussion_r43342070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -146,7 +146,11 @@ case class Alias(child:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152030521
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152031892
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152034501
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152034495
**[Test build #44549 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44549/consoleFull)**
for PR 9343 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152034499
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152038598
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152038614
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user nongli opened a pull request:
https://github.com/apache/spark/pull/9343
[SPARK-11329] [SQL] Support star expansion for structs.
1. Supporting expanding structs in Projections. i.e.
"SELECT s.*" where s is a struct type.
This is fixed by allowing the expand
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152031447
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152031915
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152034170
**[Test build #44549 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44549/consoleFull)**
for PR 9343 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9343#issuecomment-152038777
**[Test build #44555 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44555/consoleFull)**
for PR 9343 at commit
62 matches
Mail list logo
