[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-163690659 **[Test build #47525 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47525/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-163716405 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-163716212 **[Test build #47525 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47525/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-163716408 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9923#discussion_r46954224 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala --- @@ -41,7 +42,10 @@ private[netty] class NettyStreamManager(rpcEnv:

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9923#discussion_r46954341 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala --- @@ -31,6 +31,7 @@ private[netty] class NettyStreamManager(rpcEnv:

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9923#discussion_r46954401 --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala --- @@ -179,6 +179,24 @@ private[spark] trait RpcEnvFileServer { */ def

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9923#discussion_r46954012 --- Diff: repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala --- @@ -90,6 +94,11 @@ class ExecutorClassLoader(conf: SparkConf, classUri:

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9923#discussion_r46954272 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala --- @@ -41,7 +42,10 @@ private[netty] class NettyStreamManager(rpcEnv:

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-162885919 IIUC, http server is useless once we remove akka? Can you add a line of comment there as well? LGTM. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9923#discussion_r46995428 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyStreamManager.scala --- @@ -41,7 +42,10 @@ private[netty] class NettyStreamManager(rpcEnv:

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-162982557 > IIUC, http server is useless once we remove akka? There's the http-based broadcast server, which IIRC is not the default. Does anyone even use that these days?

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-162988651 **[Test build #47354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47354/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-163017372 **[Test build #47354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47354/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-163017766 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-163017771 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-162622609 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-162622605 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-07 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-162616881 Given the silence I guess people are ok with the patch, so I'll push this soon. Meanwhile, retest this please. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-161748205 **[Test build #47155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47155/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-161782431 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-161782429 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-161782226 **[Test build #47155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47155/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/9923#discussion_r46588091 --- Diff: repl/src/test/scala/org/apache/spark/repl/ExecutorClassLoaderSuite.scala --- @@ -18,24 +18,29 @@ package org.apache.spark.repl

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-03 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-161738538 looks reasonable to me, I tested out a repl with both netty & akka in local-cluster mode as well. Would appreciate another set of eyes on it. --- If your project is

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-12-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/9923#discussion_r46589628 --- Diff: repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkIMain.scala --- @@ -96,10 +96,9 @@ import org.apache.spark.annotation.DeveloperApi

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159777630 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159777633 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159783299 **[Test build #46731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46731/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159781995 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159798160 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159797999 **[Test build #46731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46731/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159798159 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159777489 **[Test build #46710 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46710/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159698894 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159698899 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159736909 **[Test build #46710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46710/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-25 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159734212 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-23 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/9923 [SPARK-11563] [core] [repl] Use RpcEnv to transfer REPL-generated classes. This avoids bringing up yet another HTTP server on the driver, and instead reuses the file server already managed by the

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159113525 **[Test build #46566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46566/consoleFull)** for PR 9923 at commit

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-23 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159120159 /cc @rxin @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159134288 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159134286 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9923#issuecomment-159134192 **[Test build #46566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46566/consoleFull)** for PR 9923 at commit