Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157482003
Thanks, updated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157507154
Rebased to pull PipelineSuite from master.
I removed the failing part of the PipelineSuite. It was not really needed
since other tests already check that
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157484976
**[Test build #46102 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46102/consoleFull)**
for PR 9749 at commit
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9749#discussion_r45118179
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -19,23 +19,30 @@ package org.apache.spark.ml.util
import
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157477581
LGTM except one minor issue commented inline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157494838
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157494727
**[Test build #46102 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46102/consoleFull)**
for PR 9749 at commit
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9749#discussion_r45106730
--- Diff: mllib/src/test/scala/org/apache/spark/ml/util/TempDirectory.scala
---
@@ -39,7 +39,12 @@ trait TempDirectory extends BeforeAndAfterAll { self:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157494844
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9749#discussion_r45106138
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -64,6 +66,47 @@ trait DefaultReadWriteTest extends TempDirectory {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157508378
**[Test build #46110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46110/consoleFull)**
for PR 9749 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157521919
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157523670
Merged into master and branch-1.6. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157521754
**[Test build #46110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46110/consoleFull)**
for PR 9749 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157521921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157223444
Oops, I just realized I forgot to save the parent field in both this and
Pipeline. Shall we just document that it does not get saved, and handle it for
1.7?
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157224825
**[Test build #46032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46032/consoleFull)**
for PR 9749 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157224959
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9749#discussion_r45005571
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -64,6 +66,47 @@ trait DefaultReadWriteTest extends TempDirectory
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157217325
**[Test build #46032 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46032/consoleFull)**
for PR 9749 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9749#issuecomment-157224961
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9749#discussion_r45005373
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -64,6 +66,47 @@ trait DefaultReadWriteTest extends TempDirectory
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/9749
[SPARK-11763] [ML] Add save,load to LogisticRegression Estimator
Add save/load to LogisticRegression Estimator, and refactor tests a little
to make it easier to add similar support to other
24 matches
Mail list logo
