Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220772184
When would the addendum be checked in ?
For people using Java 7, it is inconvenient because they have to modify
Decimal.scala otherwise the compilation would
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220720146
See #13233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220716220
Looks like bigintval.longValue() should have been used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-22071
This seems to have broken build for Java 7:
```
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala:137:
value longValueExact is not a member of
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220516202
thanks, merging to master and 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220400980
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220400977
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220400560
**[Test build #58872 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58872/consoleFull)**
for PR 10125 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220375820
**[Test build #58872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58872/consoleFull)**
for PR 10125 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220373752
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220373756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220373429
**[Test build #58869 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58869/consoleFull)**
for PR 10125 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220361041
I will push the latest one after jenkins finish. Thanks very much !
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63900108
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java ---
@@ -163,7 +168,9 @@ void validateDataFrameWithBeans(Bean bean,
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63900146
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java ---
@@ -182,6 +189,8 @@ void validateDataFrameWithBeans(Bean bean,
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220357884
mostly LGTM, pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63897785
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java ---
@@ -182,6 +189,8 @@ void validateDataFrameWithBeans(Bean bean,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63897657
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java ---
@@ -163,7 +168,9 @@ void validateDataFrameWithBeans(Bean bean,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220345646
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220347233
**[Test build #58869 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58869/consoleFull)**
for PR 10125 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220346292
retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220345648
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63880607
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -109,6 +109,7 @@ object DecimalType extends AbstractDataType {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63835534
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -109,6 +109,7 @@ object DecimalType extends AbstractDataType {
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220237290
@cloud-fan I tried, and it still fail. It didn't go through the
createDataFrame you added in SparkSession.
It went with this createDataFrame(data:
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220202547
#13008 is merged, can you revert the `CatalystTypeConverters` changes and
see if it still works? Thanks!
---
If your project is set up for it, you can reply to this
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220078687
sure, I will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63711651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
@@ -326,6 +327,7 @@ object CatalystTypeConverters {
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-220037011
@cloud-fan can you help take a look? I have made changes based on your
comments. Thanks.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219963858
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219963862
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219963582
**[Test build #58754 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58754/consoleFull)**
for PR 10125 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219952277
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219952272
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219952102
**[Test build #58749 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58749/consoleFull)**
for PR 10125 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219945609
**[Test build #58754 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58754/consoleFull)**
for PR 10125 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219945586
I just did rebase to solve the conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219945597
retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63655581
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
@@ -321,11 +323,13 @@ object CatalystTypeConverters
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219938017
**[Test build #58749 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58749/consoleFull)**
for PR 10125 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219888712
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219888690
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219888714
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219888687
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219888571
**[Test build #58724 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58724/consoleFull)**
for PR 10125 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219888573
**[Test build #58723 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58723/consoleFull)**
for PR 10125 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219885198
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219885199
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219885069
**[Test build #58721 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58721/consoleFull)**
for PR 10125 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219866811
**[Test build #58724 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58724/consoleFull)**
for PR 10125 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219865688
**[Test build #58723 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58723/consoleFull)**
for PR 10125 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219862158
**[Test build #58721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58721/consoleFull)**
for PR 10125 at commit
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63608338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
@@ -321,11 +323,13 @@ object CatalystTypeConverters
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63284859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -129,6 +129,23 @@ final class Decimal extends Ordered[Decimal] with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63276327
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
@@ -321,11 +323,13 @@ object CatalystTypeConverters
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63276311
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -129,6 +129,23 @@ final class Decimal extends Ordered[Decimal] with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219141188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219141172
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219140939
**[Test build #58588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58588/consoleFull)**
for PR 10125 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219136788
I just run the ./dev/mima locally, it works,
[info] Done packaging.
[info] spark-examples: previous-artifact not set, not analyzing binary
compatibility
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219136812
retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219120904
**[Test build #58587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58587/consoleFull)**
for PR 10125 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219120938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219120935
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219120384
**[Test build #58588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58588/consoleFull)**
for PR 10125 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219120180
@srowen @davies @cloud-fan I updated the code, can you help review? Sorry
for the delay. Thanks.
---
If your project is set up for it, you can reply to this email
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63228007
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ScalaReflectionRelationSuite.scala
---
@@ -34,7 +34,13 @@ case class ReflectData(
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r63227670
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ScalaReflectionRelationSuite.scala
---
@@ -34,7 +34,13 @@ case class ReflectData(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-219119071
**[Test build #58587 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58587/consoleFull)**
for PR 10125 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-217526107
@srowen: sorry for the long delay. I will work on it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-217508314
Ping @kevinyu98 -- update the PR or close it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47871490
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -69,6 +68,16 @@ final class Decimal extends Ordered[Decimal] with
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47871566
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -362,6 +371,8 @@ object Decimal {
def apply(value:
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47866879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
@@ -326,6 +326,7 @@ object CatalystTypeConverters {
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47866947
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
---
@@ -75,6 +75,7 @@ object JavaTypeInference {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47681228
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
---
@@ -75,6 +75,7 @@ object JavaTypeInference {
case
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47681385
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -362,6 +371,8 @@ object Decimal {
def apply(value:
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47681350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -69,6 +68,16 @@ final class Decimal extends Ordered[Decimal] with
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-164599822
ok to test @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-164600862
**[Test build #47689 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47689/consoleFull)**
for PR 10125 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-164616755
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-164616756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-164616643
**[Test build #47689 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47689/consoleFull)**
for PR 10125 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10125#discussion_r47588566
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
---
@@ -326,6 +326,7 @@ object CatalystTypeConverters {
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/10125#issuecomment-161707755
Hello Sean: I am sorry, I forgot to update the title and description. I
have made the changes, please let me know if anything needs to be changed.
Thanks.
Kevin
86 matches
Mail list logo
