Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r54676391
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,29 @@ private[spark] class Coa
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r54175315
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,29 @@ private[spark] class Coa
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-180027619
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-180027620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51928513
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -60,6 +62,12 @@ private[spark] class Coars
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-180027296
**[Test build #50755 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50755/consoleFull)**
for PR 10319 at commit
[`1181a05`](https://g
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51930126
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -60,6 +62,12 @@ private[spark] class Coar
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51929188
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -60,6 +62,12 @@ private[spark] class Coarse
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51927649
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -60,6 +62,12 @@ private[spark] class Coarse
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10319
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179981696
LGTM merged into master. The last commit didn't change any code so this
can't fail tests.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179976865
**[Test build #50755 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50755/consoleFull)**
for PR 10319 at commit
[`1181a05`](https://gi
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179968762
@dragos removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51910856
--- Diff: docs/running-on-mesos.md ---
@@ -387,6 +387,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179958972
@drcrallen probably [my
comment](https://github.com/apache/spark/pull/10319#discussion_r51693326) and
@andrewor14'r reply were buried by the GitHub interface. The consen
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179441344
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179441349
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179440696
**[Test build #50667 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50667/consoleFull)**
for PR 10319 at commit
[`75887c4`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179392112
**[Test build #50667 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50667/consoleFull)**
for PR 10319 at commit
[`75887c4`](https://gi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51762702
--- Diff: docs/running-on-mesos.md ---
@@ -387,6 +387,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-179386654
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51693326
--- Diff: docs/running-on-mesos.md ---
@@ -387,6 +387,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178952071
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178952067
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178951726
**[Test build #50616 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50616/consoleFull)**
for PR 10319 at commit
[`75887c4`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178897207
**[Test build #50616 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50616/consoleFull)**
for PR 10319 at commit
[`75887c4`](https://gi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51657811
--- Diff: docs/running-on-mesos.md ---
@@ -387,6 +387,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178893454
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178879309
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178879307
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178879167
**[Test build #50593 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50593/consoleFull)**
for PR 10319 at commit
[`75887c4`](https://g
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178850761
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50593/consoleFull
is still running
---
If your project is set up for it, you can reply to this em
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178850512
Fail was dumb (couldn't fetch from git). Needs retest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178844897
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178844895
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178841453
**[Test build #50593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50593/consoleFull)**
for PR 10319 at commit
[`75887c4`](https://gi
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178835670
@andrewor14 Addressed comments except for
https://github.com/apache/spark/pull/10319#discussion_r51638882
---
If your project is set up for it, you can reply to this
Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51638882
--- Diff: docs/running-on-mesos.md ---
@@ -387,6 +387,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51638713
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,27 @@ private[spark] class Coa
Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51638750
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,27 @@ private[spark] class Coa
Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51637351
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,27 @@ private[spark] class Coa
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-178162846
@drcrallen This looks great, thanks for fixing the issue. I left a few
minor comments. Once you fix them I'll merge this.
---
If your project is set up for it, you
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51471696
--- Diff: docs/running-on-mesos.md ---
@@ -387,6 +387,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51471308
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,27 @@ private[spark] class Co
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51470918
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,27 @@ private[spark] class Co
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51470974
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,27 @@ private[spark] class Co
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51470346
--- Diff: docs/running-on-mesos.md ---
@@ -387,6 +387,13 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51470296
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -60,6 +62,12 @@ private[spark] class Coar
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177964792
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177964790
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177964239
**[Test build #50488 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50488/consoleFull)**
for PR 10319 at commit
[`b9e1c77`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177917664
**[Test build #50488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50488/consoleFull)**
for PR 10319 at commit
[`b9e1c77`](https://gi
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177912252
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177912182
The error seems spurious:
```
[info] *** 1 TEST FAILED ***
[error] Failed: Total 385, Failed 1, Errors 0, Passed 384, Ignored 2
[error] Failed tests:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177012681
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177012684
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-177012559
**[Test build #50410 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50410/consoleFull)**
for PR 10319 at commit
[`b9e1c77`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176977605
**[Test build #50410 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50410/consoleFull)**
for PR 10319 at commit
[`b9e1c77`](https://gi
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176972208
@drcrallen sorry I don't think everyone has the permissions to trigger
jenkins, I'll help watch this
---
If your project is set up for it, you can reply to this email
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176972121
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176971876
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176948629
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176948634
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176948394
**[Test build #50393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50393/consoleFull)**
for PR 10319 at commit
[`b9e1c77`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176903099
**[Test build #50393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50393/consoleFull)**
for PR 10319 at commit
[`b9e1c77`](https://gi
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176899821
`mvn scalastyle:check` reproduces the error. fixing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176894846
**[Test build #50390 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50390/consoleFull)**
for PR 10319 at commit
[`0a24530`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176895198
**[Test build #50390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50390/consoleFull)**
for PR 10319 at commit
[`0a24530`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176895207
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176895203
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176892060
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176890203
Failed on git fetch. @dragos how do I fix that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176874651
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176874655
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51287938
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,23 @@ private[spark] class Coa
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176869277
```spark charlesallen$ ./dev/lint-scala
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
MaxPermSize=512m; support was removed in 8.0
Scalastyle chec
Github user drcrallen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51287135
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,23 @@ private[spark] class Coa
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176848352
I think besides the only comment I have everything else LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r51281443
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,23 @@ private[spark] class Coars
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176845715
@dragos we can certainly review it first, @andrewor14 has been educating me
about the review process and how Spark community typically review things after
it clears CI.
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176828137
Not sure if this is what you tried, but you can run only the style checks
using `dev/lint-scala`
---
If your project is set up for it, you can reply to this email and h
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176826287
@dragos thanks. My scalastyle keeps failing locally
(https://github.com/sbt/sbt/issues/2295), I'll see if I can get it fixed so
this stops failing scalastyle.
---
I
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176761491
I don't see the point of holding back a review until an import is moved two
lines above. Better give the feedback now, so there's not so many
back-and-forths. This has b
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176526812
@drcrallen sorry for the delay, can you please fix the scala style tests
first? will take a look once you update it.
---
If your project is set up for it, you can repl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176444359
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176444360
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176444351
**[Test build #50300 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50300/consoleFull)**
for PR 10319 at commit
[`41543e0`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176443848
**[Test build #50300 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50300/consoleFull)**
for PR 10319 at commit
[`41543e0`](https://gi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-176338070
This still hasn't run tests yet because it's still failing scala style.
Also it looks a little out of date. @drcrallen would you mind rebasing to
master and fixing
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-173748543
@tnachen / @andrewor14 ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172793031
LGTM! Thanks @drcrallen . @tnachen @andrewor14 please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172732607
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172732603
**[Test build #49659 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49659/consoleFull)**
for PR 10319 at commit
[`b781297`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172732605
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172732497
**[Test build #49659 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49659/consoleFull)**
for PR 10319 at commit
[`b781297`](https://gi
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172731505
@dragos Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user drcrallen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172698287
Thanks for feedback. I'll get to the fixes here very shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172504737
Let's try to move this forward. Looks like there's still e few things to do:
- [ ] rebase on master
- [ ] increase the sleep interval
- [ ] document the n
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172091910
You're right about the callback for emptying the map, and also about the
sleep interval.
---
If your project is set up for it, you can reply to this email and have you
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172041940
I think that either case just looking at stop isn't enough since we are
relying on the callback to empty the executors map for us to exit the loop
before the timeout, s
1 - 100 of 123 matches
Mail list logo
