Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-170765275
I'm going to merge this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10445
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-167975046
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-167975047
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-167956491
It seems to me the change is not necessary and might actually complicate
the analyzer code itself due to the reliance on the dsl implicits and this
"unapply" (I didn't
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10445#discussion_r48592772
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -473,112 +474,97 @@ object OptimizeIn extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-167960210
**[Test build #48471 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48471/consoleFull)**
for PR 10445 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-167957517
Update: the unapply is probably fine. I still wouldn't have the dsl though.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-167960416
Thanks for the review! I reverted the DSL part and those changes that are
not obviously correct.
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-167974984
**[Test build #48471 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48471/consoleFull)**
for PR 10445 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-167915927
It's much more readable! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/10445
[SPARK-12498][SQL][MINOR] BooleanSimplication simplification
Scala syntax and existing Catalyst expression DSL allows us to refactor the
`BooleanSimplification` optimization rule to a clearer
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-166870629
**[Test build #48237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48237/consoleFull)**
for PR 10445 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-166891869
**[Test build #48237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48237/consoleFull)**
for PR 10445 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-166891943
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10445#issuecomment-166891946
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
16 matches
Mail list logo
